search

clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 42 forks source link

Enable gocritic linter #717

Open mdhorn opened 4 years ago

mdhorn commented 4 years ago

Enable the gocritic linter for golangci-lint and fix the flagged issues.

We should consider these settings when implementing:

gocritic:
  enabled-tags:
    - diagnostic
    - experimental
    - opinionated
    - performance
    - style
  disabled-checks:
    - dupImport # https://github.com/go-critic/go-critic/issues/845
    - ifElseChain
    - octalLiteral
    - whyNoLint
    - wrapperFunc

The output of this all seems reasonable and worth implementing. Many of these may be overlapped with Enable gosimple linter #714