clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 42 forks source link

Fix setting the boot partition #718

Closed mdhorn closed 4 years ago

mdhorn commented 4 years ago

Changes proposed in this pull request:

karthikprabhuvinod commented 4 years ago

@mdhorn sorry about the delay...will review first thing in morning

mdhorn commented 4 years ago

@karthikprabhuvinod Found and fixed the other issue you mentioned with using installer.yaml and setting the alias.

karthikprabhuvinod commented 4 years ago

@mdhorn cool did you forcepush towards another branch? Looks like you changes from completions PR..check force-pushed

mdhorn commented 4 years ago

completions

Nope, I rebased against the upstream master as well as adding fixes.

karthikprabhuvinod commented 4 years ago

I perfomed various tests and they seem to work well.

e,g: Installed with :

# clear-linux-config

# installer.yaml
#
# This YAML file generates the basic TUI installer image for
# Clear Linux OS

# Switch between aliases if you want to install to an actual block device.
# i.e /dev/sda
block-devices: [
   {name: "installerboot", file: "installer.img"},
   {name: "installerother", file: "installer.img"}
]

targetMedia:
- name: ${installerboot}
  type: disk
  children:
  - name: ${installerboot}1
    fstype: vfat
    mountpoint: /boot
    size: "150M"
    type: part
- name: ${installerother}
  type: disk
  children:
  - name: ${installerother}1
    fstype: swap
    size: "256M"
    type: part
  - name: ${installerother}2
    fstype: ext4
    mountpoint: /
    size: "2.6G"
    type: part

result:

NAME      MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
loop0       7:0    0    15G  0 loop
├─loop0p1 259:3    0   255M  0 part
└─loop0p2 259:4    0   2.6G  0 part
loop1       7:1    0    15G  0 loop
└─loop1p1 259:1    0   149M  0 part

Worked well for me :)