clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 42 forks source link

Enable lvm root #746

Closed mdhorn closed 4 years ago

mdhorn commented 4 years ago

Fixes Issue: #8

Changes proposed in this pull request:

mdhorn commented 4 years ago

@karthikprabhuvinod Still debugging why the boot hangs on mounting additional logical volumes, but if you have the bandwidth, please start reviewing this changeset.

mdhorn commented 4 years ago

Changewise LGTM to mark. I was thinking if you can add a functional test for this. but I will leave it upto you. Functional test: To add a test we create a LVMs with our desired labels and run advanced partitioning on it and check installation succeededs and fstab has required entries

@mdhorn any comments?

Functional test pushed.

meklonets commented 3 years ago

Sorry, but I haven't got is it possible to install root on LVM now or not? Because installer doesn't see my lvm partitions. He sees the hole physical drive.

mdhorn commented 3 years ago

Sorry, but I haven't got is it possible to install root on LVM now or not? Because installer doesn't see my lvm partitions. He sees the hole physical drive.

You need to use the Advanced Installation selection for the media and ensure you create Logical Volume Names which match the required labeling syntax: https://github.com/clearlinux/clr-installer/blob/master/scripts/InstallerYAMLSyntax.md#advanced-installation-media-targets If you have Logical Volume names which match CLR_ROOT and a standard partition label for CLR_BOOT (boot can not be on an LVM) the installation will proceed. All other partitional are optional.