search

clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 42 forks source link

clr-installer fails when trying to do a clean install on an old ZFS partition #753

Open omkhar opened 4 years ago

omkhar commented 4 years ago

Describe the bug I attempted to install Clear Linux desktop over an old Ubuntu which used ZFS. ISO used: clear-33590-live-desktop

To Reproduce Steps to reproduce the behavior:

  1. Install Ubuntu 20.04, select ZFS
  2. dd clear-33590-live-desktop.iso to USB stick
  3. Boot into Clear Linux
  4. Launch installer, select "Destructive install"
  5. Installer dies right after trying to partition

Expected behavior

  1. Installer should proceed. If you used wipefs on the partition first, installer proceeds fine. Presumably the installer dies when it sees a ZFS signature on the partition.

Environment (please complete the following information):

mdhorn commented 3 years ago

Destructive install should replace the disk partition table, so we shouldn't see the previous ZFS. Haven't had an opportunity to wipe a drive and test this yet; need to reproduce to get the /root/clear-installer.log file.

omkhar commented 3 years ago

ZFS actually peppers some signature/magic throughout the block device, simply clearing the partition table won't be enough, if the partitioning tool is smart enough to read it. I'm building a VM to test and provide a clear-installer.log as requested.

omkhar commented 3 years ago

Here's both the Ubuntu installer as well as a log of the Clear Linux install failing. bug-753-logs.zip

omkhar commented 3 years ago

Here is what wipes reports as being present on /dev/sda (block device for clear install)

wipefs.txt

omkhar commented 3 years ago

my guess is that https://github.com/clearlinux/clr-installer/blob/master/storage/block_devices_ops.go needs to be amended to run wipefs -a during a destructive install against partitions before laying down the filesystem

omkhar commented 3 years ago
image

results of running wipefs -a

omkhar commented 3 years ago

This time I had to run dd if=/dev/zero of=/dev/sda bs=1G before the installer would work. wipefs -a was not enough.

mdhorn commented 3 years ago

@omkhar Thanks for the follow up. I'm surprised wipefs doesn't clear the file system information; that's is how we prep for an encrypted installed.

omkhar commented 3 years ago

quite easy to reproduce, please let me know if you require further artifacts?