clearlinux / clr-installer

Clear Linux* OS Installer
GNU General Public License v3.0
92 stars 43 forks source link

`post-install` commands are executed with `bash -l` so it's creating a new login shell #813

Open ThaDaVos opened 2 months ago

ThaDaVos commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

It seems the post-install commands are called with bash -l when using clr-installer --config ... in the live-server installer - this creates a new bash login shell, which in turns triggers .bash_login if it exists - I have a modified live-server image which has the .bash_login in the roots home directory, so it's getting called again, which isn't functional as the script it calls requires input from the user, so halting the post-install script without any means of interaction

To Reproduce Steps to reproduce the behavior:

  1. Create a custom live-iso which has a .bash_login inside the root home directory which requests users input
  2. Use a config with a post-install command
  3. call clr-installer with your config
  4. See it hang indefinitely

Expected behavior A clear and concise description of what you expected to happen.

I expected it to be called with just bash not bash -l, so to execute normally

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.