clearlinux / common

Developer tooling framework
GNU General Public License v3.0
54 stars 23 forks source link

make koji: check remote tag exists beforehand #18

Closed busykai closed 4 years ago

busykai commented 4 years ago

CC: @phmccarty

phmccarty commented 4 years ago

@busykai Similar to the feedback from @bryteise, I would like to hear about the scenario(s) where it is helpful to have this check.

Whenever I hit the case when a remote tag already exists, the git push command fails. Of course, checking git ls-remote --tags ... beforehand is helpful to produce a better error message, but otherwise, are your changes capturing additional scenarios I'm not thinking of?

busykai commented 4 years ago

Local tag is not created. There's no good reason to litter if you can avoid it.

phmccarty commented 4 years ago

Okay, that's fair. I just wanted to make sure there weren't any other scenarios I was not thinking of :-)

phmccarty commented 4 years ago

Fixed with cbb1d9688ebf9368e07b08b26d1648e5cd2f1f8a