Closed sofar closed 9 years ago
which, in the case of CSV output results in errors ending up in the CSV file.
e.g. "srpm directory does not exist or is not a directory" is just printed to stdout.
main.c: printf("Adding to bug database: %s\n -%s\n", main.c: printf("Error: Aborting adding CVEs to bug database due to errors\n"); main.c: printf("Unknown type: \"%s\".\nCurrently supported types: %s\n", forced_type, SUPPORTED_TYPES); main.c: printf("Usage: %s [path-to-source-spec|path-to-source-list-file]\n", argv[0]); main.c: printf("%s does not exist\n", argv[1]); main.c: printf("srpm directory does not exist or is not a directory\n"); main.c: printf("Unsupported package type\n"); main.c: printf("Warning: Not found: %s\n", path); main.c: printf("Unable to determine package type, bailing\n"); main.c: printf("Unsupported package type\n"); main.c: printf("Unsupported file: %s\n", target); main.c: printf("No source files were encountered, aborting\n"); main.c: printf("Scanned %d source file%s\n", size, size > 1 ? "s" : "");
almost all of these belong in stderr, really. Even Usage can go to stderr.
Yeah I should've done this one quicker, sorry :) At some point I'll move us to better debug macros too, to handle quiet mode, etc.
which, in the case of CSV output results in errors ending up in the CSV file.
e.g. "srpm directory does not exist or is not a directory" is just printed to stdout.
main.c: printf("Adding to bug database: %s\n -%s\n", main.c: printf("Error: Aborting adding CVEs to bug database due to errors\n"); main.c: printf("Unknown type: \"%s\".\nCurrently supported types: %s\n", forced_type, SUPPORTED_TYPES); main.c: printf("Usage: %s [path-to-source-spec|path-to-source-list-file]\n", argv[0]); main.c: printf("%s does not exist\n", argv[1]); main.c: printf("srpm directory does not exist or is not a directory\n"); main.c: printf("Unsupported package type\n"); main.c: printf("Warning: Not found: %s\n", path); main.c: printf("Unable to determine package type, bailing\n"); main.c: printf("Unsupported package type\n"); main.c: printf("Unsupported file: %s\n", target); main.c: printf("No source files were encountered, aborting\n"); main.c: printf("Scanned %d source file%s\n", size, size > 1 ? "s" : "");
almost all of these belong in stderr, really. Even Usage can go to stderr.