clearlinux / cve-check-tool

Original Automated CVE Checking Tool
GNU General Public License v2.0
205 stars 78 forks source link

Missing New CVEs when cve_db_get_issues() called in track_bugs() #18

Closed johnwhiteman closed 8 years ago

johnwhiteman commented 9 years ago

Reproduce: Delete NVDS Temporary Move *.nopatch to a different directory cd bind-utils cve-check-tool -b bind-utils.spec

Here you will see the updates as expected with the new database being created.

If cve_db_get_issues() gets called I believe it should return the new CVEs especially since its a new database and the no patch files were removed and no entries exist in the JIRA. The call is not returning the new CVEs so the JIRA plugin doesn't get them.

  if (self->mapping) {
                    q = g_hash_table_lookup(self->mapping, pkg->name);
            }
            cves = cve_db_get_issues(self->cve_db, q ? q : pkg->name, pkg->version);
            if (!cves) {
                    continue;
            }
ikeydoherty commented 8 years ago

Is this still an issue ? Not sure I entirely get it either :]

johnwhiteman commented 8 years ago

Hmm. It's been so long. I believe we can close as this since was probably related to the crash issue reported and fixed last year.

ikeydoherty commented 8 years ago

yeah I started to reorg and refresh the repo, sorry :D

johnwhiteman commented 8 years ago

If there is anything you need from my side let me know.

ikeydoherty commented 8 years ago

Well at some stage we'll need to move the JIRA plugin around, as I want to remove glib everywhere possible (but I know its going to be nigh impossible to get it out of jira)

So it may just be that we also make JIRA fit the new API with it being a true plugin, we can add new capabilities for it to interact with it.

I'm tracking the required deglibification in #21

I think its ok to keep glib in this plugin, and API method is the way to go =)

johnwhiteman commented 8 years ago

I have no problem taking glib out of JIRA plugin for starters. I may have a few cycles to do this.

ikeydoherty commented 8 years ago

Oh ok :) Well I got some things kickstarted, and I put the Hashmap replacement in, and I'll land the List replacement too (If we need specifically a GSList replacement too I can whack one of those in for an easier port)