search

clearlinux / cve-check-tool

Original Automated CVE Checking Tool
GNU General Public License v2.0
204 stars 78 forks source link

Next2 #26

Closed serhepopovych closed 8 years ago

serhepopovych commented 8 years ago

This is my v2 series to address various aspects related to the database integrity and results consistency.

I've removed most of the glib dependencies from update.c all from cve-db-lock.c infrastructure, change template_context_process_line() and template_string() to use/return cve_string to avoid strlen() usage.

Replace glib SHA256 digest routines with ones from openssl and simplify NVD data integrity checks greatly compared to v2 series. Choose minimal supported openssl version as 1.0.0 since 0.9.8 not supported for security updates starting from 2015-01-01.

Tested both compile and runtime for CSV and HTML report generation using meta-security-isafw on YOCTO. Seems everything is work as expected.

Please review and possibly merge. And as always, comments and suggestions are welcome.

Thanks.

ikeydoherty commented 8 years ago

OK so on the whole, good, but I'm really not keen on the HTML output change. If anything an "-o" flag should've been added to change the default output path. This actually does break the workflow on Solus.

With that said I may just hold off on the update in Solus, and add the "-o" flag myself. I'm also rewriting the TemplateContext stuff locally to enable a far more complex HTML report (Which is a requirement for me right now)

ikeydoherty commented 8 years ago

Test suite doesn't actually compile without compensating the use of the extern symbol..

ikeydoherty commented 8 years ago

Thanks for your changes! :) I'll make the changes now I mentioned

ikeydoherty commented 8 years ago

HTML output re-enabled via -o with: https://github.com/ikeydoherty/cve-check-tool/commit/2c88c7ed306f4983cb81ee7eafcbebcc0b36f1b1