search

clearlinux / distribution

Placeholder repository to allow filing of general bugs/issues/etc against the Clear Linux OS for Intel Architecture linux distribution
524 stars 29 forks source link

"shells" bundle is required for bash-completion after 33190 #2241

Open lars-nvhgroup opened 3 years ago

lars-nvhgroup commented 3 years ago

Thanks to all. I was helped by the installation of a shells bundle - swupd bundle-add shells The strange thing is that before version 33190 everything worked without it.

Originally posted by @ViZaVi70 in https://github.com/clearlinux/distribution/issues/1997#issuecomment-636298191

Prior to 33190, it was working with these bundles installed:

It is still an issue in 34140

As mentioned in #1997 a workaround is possible by installing "shells", but does not fix the core issue, since change is not communicated or expected.

lebensterben commented 3 years ago

I propose to move bash-comletion package to system-basic.

phmccarty commented 3 years ago

@lars-whta Are you referring to bash completion in general, or the completions specific to swupd?

If the latter, ever since https://github.com/clearlinux/swupd-client/pull/1535 was merged, the swupd completions require bash-completion, whereas before, they did not. The swupd-client package does not (and probably should not) declare a runtime dependency on bash-completion.

@lebensterben Do you mean sysadmin-basic instead?

lars-nvhgroup commented 3 years ago

@lars-whta Are you referring to bash completion in general, or the completions specific to swupd?

If the latter, ever since clearlinux/swupd-client#1535 was merged, the swupd completions require bash-completion, whereas before, they did not. The swupd-client package does not (and probably should not) declare a runtime dependency on bash-completion.

@lebensterben Do you mean sysadmin-basic instead?

It wasn't clear enough, but yes only swupd specifically.

lebensterben commented 3 years ago

@lars-whta Are you referring to bash completion in general, or the completions specific to swupd? ...

@phmccarty Yes. I suggest sysadmn-basic to include https://github.com/clearlinux-pkgs/bash-completion

But it seems more complicated than that because os-core-update and its dependencies doesn't seem to require sysadmin-basic.

lebensterben commented 3 years ago

user-basic will install bash-completion package, and this is what this bundle is designed for. I can add a test in swupd.bash and suggest users to install user-basic bundle if bash-completion is not found.

phmccarty commented 3 years ago

I can add a test in swupd.bash and suggest users to install user-basic bundle if bash-completion is not found.

That sounds like a good approach for now.

lebensterben commented 3 years ago

@phmccarty https://github.com/clearlinux/swupd-client/pull/1594 will close this.

It looks like this:

lucius@clr-lucius ~ $ swupd
Please install 'bash-completion' with  'swupd bundle-add shells'