clearlinux / distribution

Placeholder repository to allow filing of general bugs/issues/etc against the Clear Linux OS for Intel Architecture linux distribution
521 stars 29 forks source link

WineGUI update #3178

Closed Aqua1ung closed 3 weeks ago

Aqua1ung commented 3 weeks ago

@fenrus75: Many thanks for porting WineGUI to CL! You, however, grabbed a very old version (1.0.0.0). Please head over here and download the latest. Many thanks!

K1ngfish3r commented 3 weeks ago

it's 2.6.1 no? https://github.com/clearlinux-pkgs/winegui/blob/8e3c7548aeaea11040caa4342df2c06cee786b83/Makefile#L2

Aqua1ung commented 3 weeks ago

it's 2.6.1 no?

Yes, the newest is 2.6.1. Yet sudo swupd bundle-add winegui installs this:

Screenshot from 2024-09-02 14-31-43

Screenshot from 2024-09-02 14-29-14

K1ngfish3r commented 3 weeks ago

image seems to be reporting itself as 1.0.0 hmm

fenrus75 commented 3 weeks ago

we should have 2.6.1 .. not sure why it thinks it's 1.0 though

On Mon, Sep 2, 2024 at 12:43 PM K1ngfish3r @.***> wrote:

image.png (view on web) https://github.com/user-attachments/assets/bddec815-0fe8-4e2c-90b1-a0a93df52ce3 seems to be reporting itself as 1.0.0 hmm

— Reply to this email directly, view it on GitHub https://github.com/clearlinux/distribution/issues/3178#issuecomment-2325242239, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ54FPUSQF4A4YBSLEZGELZUS5V3AVCNFSM6AAAAABNQVPUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGI2DEMRTHE . You are receiving this because you were mentioned.Message ID: @.***>

melroy89 commented 3 weeks ago

No problem, I found the issue. The version from WineGUI is determined from git tags. So the CI/CD pipeline is fully automated when creating a new release.

The best way to build from source is to use the following tar.gz instead: https://winegui.melroy.org/downloads/WineGUI-Source-v2.6.1.tar.gz

See also the WineGUI AUR package (I maintain as well): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=winegui

The only difference between the previously mentioned tar.gz file and git source is that the this tar.gz file is build during CI/CD to include a version.txt file, which is used by CMake to build the code and include the version.

This link is also part of the release assets:

image

Too bad I can't disable the GitLab generated tar.gz files, since those tar.gz files are created before CI/CD runs. Anyhow, just use: https://winegui.melroy.org/downloads/WineGUI-Source-v2.6.1.tar.gz

fenrus75 commented 3 weeks ago

I'll switch the tarbals -- is that download url going to have future releases as well? (because then our automation is likely to pick them up)

On Mon, Sep 2, 2024 at 2:19 PM Melroy van den Berg @.***> wrote:

No problem, I found the issue. The version from WineGUI is determined from git tags. So the CI/CD pipeline is fully automated when creating a new release.

The best way to build from source is to use the following tar.gz instead: https://winegui.melroy.org/downloads/WineGUI-Source-v2.6.1.tar.gz

See also the WineGUI AUR package (I maintain as well): https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=winegui

— Reply to this email directly, view it on GitHub https://github.com/clearlinux/distribution/issues/3178#issuecomment-2325309115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ54FLQQ2AAOOQZLZ4LV73ZUTI5HAVCNFSM6AAAAABNQVPUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGMYDSMJRGU . You are receiving this because you were mentioned.Message ID: @.***>

melroy89 commented 3 weeks ago

I'll switch the tarbals -- is that download url going to have future releases as well? (because then our automation is likely to pick them up)

If you mean that the new tar.gz versions will be released at: https://winegui.melroy.org/downloads/. Then the answer is yes (again use WineGUI-Source-....tar.gz).

If you want to know the latest release, I also automatically update: https://winegui.melroy.org/latest_release.txt

fenrus75 commented 3 weeks ago

I indeed meant the /downloads/ url -- we have tooling that monitors for new releases (and then notifies us) -- this helps us keep on top of new software...

thanks for the help!

On Tue, Sep 3, 2024 at 3:48 AM Melroy van den Berg @.***> wrote:

I'll switch the tarbals -- is that download url going to have future releases as well? (because then our automation is likely to pick them up)

If you mean that the new tar.gz versions will be related at: https://winegui.melroy.org/downloads/. Then the answer is yes.

If you want to know the latest release, I also automatically update: https://winegui.melroy.org/latest_release.txt

— Reply to this email directly, view it on GitHub https://github.com/clearlinux/distribution/issues/3178#issuecomment-2326209159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ54FM6VGTFCUMFS5K7YJTZUWHV7AVCNFSM6AAAAABNQVPUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWGIYDSMJVHE . You are receiving this because you were mentioned.Message ID: @.***>

melroy89 commented 3 weeks ago

I saw that the spec file is updated in commit: https://github.com/clearlinux-pkgs/winegui/commit/93443844e69e54acb9a119b17e85b001e27e6bd5. That seems all good!

I only see build dependencies (like gtkmm-3.0).. Be sure to include several important run-time dependencies also, so people have the best possible first-time experience. Here an Debian example, but you get the drill: https://gitlab.melroy.org/melroy/winegui/-/blob/main/cmake/packaging.cmake?ref_type=heads#L41

cabextract, wget, unzip, p7zip etc. are needed by other tools like Winetricks and when there are additional DDLs overrides are installed, etc. etc. This is needed when people start interacting with WineGUI and you want to avoid having people complain about missing dependencies at runtime or getting errors.

fenrus75 commented 3 weeks ago

I added cabextract to our bundle definition earlier -- just adding wget unzip and p7zip now

On Wed, Sep 4, 2024 at 12:35 PM Melroy van den Berg < @.***> wrote:

I saw that the spec file is updated in commit: clearlinux-pkgs/winegui@ 9344384 https://github.com/clearlinux-pkgs/winegui/commit/93443844e69e54acb9a119b17e85b001e27e6bd5. That seems all good!

I only see a build dependencies (like gtkmm-3.0).. Be sure to include several important run-time dependencies also, so people have the best possible first-time experience. Here an Debian example, but you get the drill: https://gitlab.melroy.org/melroy/winegui/-/blob/main/cmake/packaging.cmake?ref_type=heads#L41

cabextract, wget, unzip, p7zip etc. are needed by other tools line Winetricks and when there are additional DDLs overrides are installed, etc. etc. This is needed when people start interacting with WineGUI and you want to avoid having people complain about missing dependencies at runtime or getting errors.

— Reply to this email directly, view it on GitHub https://github.com/clearlinux/distribution/issues/3178#issuecomment-2329827103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ54FLSVY23NBUN2IZM73LZU5OH7AVCNFSM6AAAAABNQVPUYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZHAZDOMJQGM . You are receiving this because you were mentioned.Message ID: @.***>

melroy89 commented 3 weeks ago

Great! In that case, I believe this ticket can be closed. Unless there are any more questions or issues.