search

clearlinux / make-fmv-patch

MIT License
38 stars 7 forks source link

Add capability to declare specific attribute #11

Closed VictorRodriguez closed 5 years ago

VictorRodriguez commented 5 years ago

Try to provide a common fix for https://github.com/clearlinux/make-fmv-patch/issues/8

Signed-off-by: VictorRodriguez vm.rod25@gmail.com

VictorRodriguez commented 5 years ago

@zerodefect could you please help me to take a look at this PR , I am not an expert in Perl , let me know if it does not break the test ( I have already test it , but an extra eyes on this might be good )

zerodefect commented 5 years ago

Yes, I'll try it out by the end of the day tomorrow. Happy to help.

zerodefect commented 5 years ago

You beat me to it. I've just tried it this evening. It works :)

VictorRodriguez commented 5 years ago

Sorry @zerodefect my apologies, next time I will wait until your confirmation

zerodefect commented 5 years ago

I don't mind :) I thought you were waiting on me, so I didn't want you to think that I had forgotten about it.