Export flag - Githubissues

clearlinux / mixer-tools

Software update mixer and related tools

Apache License 2.0

28 stars 37 forks source link

Export flag #722

Closed reaganlo closed 4 years ago

reaganlo commented 4 years ago

Change RenameFlag to MiscFlag Change RenameFlag to MiscFlag since "rename" has been deprecated and this flag will be used as a placeholder for various other flags.
Introduce new export flag in manifests By default, files with the prefix "/bin/", "/usr/bin/" and "/usr/local/bin/" will have a new export flag "x" in the 4th byte of the flag section of the Manifest. The user can override this by using a new keyword "un-export()" in the bundle definition file. E.g. un-export(/usr/bin/file2) Fixes #708

ashleshaAtrey commented 4 years ago

After a version update, if the exported flag changes, new Manifest is not being generated for that version.

reaganlo commented 4 years ago

Thanks for testing.. will look into it..

reaganlo commented 4 years ago

After a version update, if the exported flag changes, new Manifest is not being generated for that version.

@ashleshaAtrey good catch. I've pushed a change and updated tests to handle this.

ashleshaAtrey commented 4 years ago

bundle manifests looks good now. Manfiest.full are not getting updated though. Export flag for Manifest.full files are not getting generated properly.

reaganlo commented 4 years ago

Manfiest.full are not getting updated though. Export flag for Manifest.full files are not getting generated properly.

@ashleshaAtrey I figured out a way to populate the full manifest with the export flag, but then realized that the export flag is at a bundle-file level instead of at a file level. Hence it should not be updated in the full manifest. Just confirmed with @bryteise I have updated the git commit message to make a note of this.

ashleshaAtrey commented 4 years ago

I tested the PR integrating with swupd. LGTM