search

clearlinux / mixer-tools

Software update mixer and related tools
Apache License 2.0
27 stars 37 forks source link

Skip delta creation for pure rename case #780

Closed phmccarty closed 2 years ago

phmccarty commented 2 years ago

The change in 73bf833128 resulted in "pure rename" deltas not being added to packs, but we can go one step further by not queuing these deltas to be created in the first place, saving some cycles.

phmccarty commented 2 years ago

After some local testing, I see that pure rename deltas are no longer generated (great), but then the fullfiles are added to the packs instead...

I assume that if swupd-client handles the pure rename case okay, then we don't want either the delta or fullfile in the delta pack?

fenrus75 commented 2 years ago

we don't want either indeed

the same hash check for skipping deltas yesterday was added only to the error path... and your flow doesn't get near that

On Wed, Aug 31, 2022, 12:35 Patrick McCarty @.***> wrote:

After some local testing, I see that pure rename deltas are no longer generated (great), but then the fullfiles are added to the packs instead...

I assume that if swupd-client handles the pure rename case okay, then we don't want either the delta or fullfile in the delta pack?

— Reply to this email directly, view it on GitHub https://github.com/clearlinux/mixer-tools/pull/780#issuecomment-1233342251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ54FLWDEEG7X3B24CDEGDV36XWLANCNFSM6AAAAAAQBTYQFY . You are receiving this because you commented.Message ID: @.***>

phmccarty commented 2 years ago

We want to keep the pure rename deltas for now, because swupd-client is not handling their absence cleanly.