Add command to remove orphan bundles

clearlinux / swupd-client

Software update client

Other

116 stars 61 forks source link

Add command to remove orphan bundles #1547

Closed castulo closed 4 years ago

castulo commented 4 years ago

Dependencies of orphaned bundles can cause bloat and unexpected content to be on disk. We need to remove all bundles that are not tracked or dependency of a tracked bundle. This option should also be available for 3rd-party.

Closes #1529

castulo commented 4 years ago

@otaviobp I forgot to mention this, but the PR is ready for review regardless of the failing job. That is again because of new tests in the API tests.

castulo commented 4 years ago

V2:

Rebased
Used a new pointer to iterate over the bundles list
Removed the word "orphaned" from the bundle-remove summary so instead of saying: "Successfully removed 1 orphaned bundle" it will say "Successfully removed 1 bundle"

castulo commented 4 years ago

I didn't change the logic in the code to pass the list of orphaned bundles to execute_remove_bundles_extra() because this IMO has bigger disadvantages, like having to load the manifests outside a process step, and requiring more code duplication.

castulo commented 4 years ago

I forgot to push changes for a couple of tests after pushing V2. It should be good now.