clearlinux / swupd-client

Software update client
Other
116 stars 62 forks source link

hashdump completion should complete files/directories #350

Open phmccarty opened 6 years ago

phmccarty commented 6 years ago

If I type swupd hashdump <TAB>, I would like to see a list of files and directories for completion candidates as well as the current list of hashdump command line options. This is useful because hashdump requires a filename as an argument.

icarus-sparry commented 6 years ago

Certainly possible. Bash completion already has options other than tab for completing files (Meta-/ in particular is bound to complete-filename in the default emacs based keyboard bindings) . The issue is more do we want to have a bash completion script in the source, or do we want to have a script that writes the script in the source. As we add more special cases (bundle-add and bundle-remove are already special) the program to write the script becomes more complicated than the script!

matthewrsj commented 6 years ago

@icarus-sparry I'm inclined to defer to your judgement on that.

icarus-sparry commented 6 years ago

I would love to remove the script that writes the completion script.

Whilst Rob Pike can design a new language and write a compiler for it just to be able to write essentially one program in it, I think the complexity of the completion script is not worthy of us doing the same.

matthewrsj commented 6 years ago

+1, fine with me.

phmccarty commented 6 years ago

+1 with removing the autogeneration of the completion script. The motivation for implementing autogeneration originally was to save time for the maintainer, but as the completion needs grow more complex over time, the autogeneration turns into more of a nuisance.