clearlinux / swupd-server

Software update server (deprecated)
Other
13 stars 17 forks source link

[clearlinux/swupd-server] Replace system calls by local system_argv functions. #16

Closed jrguzman-intel closed 8 years ago

jrguzman-intel commented 8 years ago

There are new functions that replace system() calls: system_argv(), system_argv_fd and system_argv_pipe(). They are based on execvp() function and they can manage any argument including filenames with characters that could be interpreted as meta-characters in a regular system() function. So no escape for the arguments needed and is less prone to errors.

Signed-off-by: Jose R Guzman jose.r.guzman.mosqueda@intel.com

phmccarty commented 8 years ago

Those are all the comments I have for now on this patch :-)

phmccarty commented 8 years ago

+1, will merge shortly.

phmccarty commented 8 years ago

I squashed the series and pushed to master.