Closed sofar closed 8 years ago
Testing: This was tested using the make check
code which validates that output manifests correctly read groups.ini
. The make check
code omits testing the conversion from bundle files to groups.ini
, but that part is trivial enough and was tested on the command line, since it's a one-liner.
The code changes look okay to me. I'll check swupd-client to see if it skips unknown fields in manifest headers.
swupd-client does skip header entries it doesn't know about...
+1
After further examination, I see manifest.c is needed by the other binaries, so groups.c must be included. So disregard my two inline comments.
Merged 7758a6
This patch extracts the [STATUS] field from our bundle information metadata, and stores it in groups.ini. From there we put the contents of this string verbatim into the manifest.
We don't interpret, encode or convert the contents of the [STATUS] field in the manifest. Instead, we just strip non-alphanumeric characters and pass the contents on. This leaves it entirely to the client to parse and interpret the value of this field in the manifest.
If the bundle file, or the groups.ini file omits any status, nothing is output to the Manifest file.