search

clearlinux / swupd-server

Software update server (deprecated)
Other
13 stars 17 forks source link

fullfiles.c: fix invalid LOG() call #42

Closed pohly closed 7 years ago

pohly commented 7 years ago

LOG() takes an additional fixed string before the format string.

Already reviewed here: https://github.com/clearlinux/swupd-server/pull/34

IMHO it would be good to add printf format function attributes to the logging functions, to catch such errors and also mismatches between the format string and the actual parameters.

https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes

phmccarty commented 7 years ago

+1