search

clearlinux / swupd-server

Software update server (deprecated)
Other
13 stars 17 forks source link

type_change: allow type change from directory to symlink #51

Closed andred closed 7 years ago

andred commented 7 years ago

At least bsdtar (on the client side) seems to handle this perfectly fine.

Signed-off-by: André Draszik git@andred.net

andred commented 7 years ago

I hope I didn't miss anything, but this in combination with https://github.com/clearlinux/swupd-client/pull/168 seems to work perfectly fine for me.

andred commented 7 years ago

I didn't actually notice https://github.com/clearlinux/swupd-server/issues/50 before, does that issue imply there is more to do?

phmccarty commented 7 years ago

@andred Yes, more work is needed to support a non-empty directory type change. The empty directory case is the trivial one.

I just wrote a summary of the current state at https://github.com/clearlinux/swupd-server/wiki/Type-changes.

phmccarty commented 7 years ago

Hmm, I see that swupd_rm() is called in swupd-client for this case already, so it may work okay after all. I'll revisit the client staging code.

tmarcu commented 7 years ago

Refer to https://github.com/clearlinux/swupd-client/issues/209 for further work on this.