search

clearly-broken-software / ninjas2

Rewrite of Ninjas sample slicer
GNU General Public License v3.0
179 stars 13 forks source link

More intuitive onset slicing #34

Open rghvdberg opened 5 years ago

rghvdberg commented 5 years ago

Currently the onset slicing works like this : 1) slice sample in even parts (raw slicing) 2) snap each slice start/end to the nearest found onset 3) remove 'dead' slices

Problems with this approach:

naught101 commented 5 years ago

We could number slices in the top left corner to make problem funding easier.

I don't think the slice overwriting is a problem. But maybe if slices have been created manually, then changing the spinbox should not change the number of slices until the slice button is manually pressed.

On 16 May 2019 2:46:16 pm AEST, rghvdberg notifications@github.com wrote:

Currently the onset slicing works like this : 1) slice sample in even parts (raw slicing) 2) snap each slice start/end to the nearest found onset 3) remove 'dead' slices

Problems with this approach:

  • dead slice problem
  • some slices can end with 0 (or smaller!) length resulting in 'dead' slices; slices with a midi note attached to it but do not produce sound
  • simply removing dead slices results in a number of slices not set by the user
  • slices can be technically valid (length > 0) but to short to be produce sound
  • if a user has manually edited slice boundaries those edits are lost because of step 1 (raw slicing)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rghvdberg/ninjas2/issues/34

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

rghvdberg commented 5 years ago

Atm slicing only happens when you hit the slice button. The color (red) of the slice digit should indicate if the slice number has changed but the slicing has been applied. I know there's a small bug because it starts with a red digit. Haven't hunted that bug yet.