add reusable workflow for dev deploy - Githubissues

clearlydefined / operations

Operational documentation and tools

2 stars 10 forks source link

add reusable workflow for dev deploy #68

Closed elrayle closed 5 months ago

elrayle commented 5 months ago

Description

Move dev deploy workflow from service to operations and generalize it for use with all primary apps (i.e. service, crawler, website)

Related Work

PR https://github.com/clearlydefined/service/pull/1091.

Summary of fixes:

Multiple issues were in the original workflow:

If the webapp publish profile secret is empty, Azure/webapps-deploy v3 doesn’t deploy but reports the deploy as passing. See Azure/webapps-deploy Issue #404.
Configs were set before running the deploy. This means that the config values in Azure are updated even if the deploy fails.

To avoid these known issues, the PR updates the workflow copied from clearlydefined/service to...

check that all required secrets are set before proceeding

NOTE: Configs cannot be moved after the deploy because they are used by the restart process kicked of by the deploy.

Follow-on Work

Issue #69

elrayle commented 5 months ago

This is superseded by the work in:

The new PRs combine the dev and deploy workflows into a single shared workflow in operations.