Update _joinExpressions to preserve precedence

clearlydefined / service

The service side of clearlydefined.io

MIT License

45 stars 40 forks source link

Update _joinExpressions to preserve precedence #1087

Closed lumaxis closed 3 months ago

lumaxis commented 6 months ago

Fixes https://github.com/clearlydefined/service/issues/1084

lumaxis commented 5 months ago

As we discussed last week, I agree and would definitely prefer to let the library handle this logic. Actually, my preference would be to either figure out if @clearlydefined/spdx can already do this through merge/flatten/expand somehow or alternatively, make changes to the library so that it can handle joining expressions for us.

lumaxis commented 4 months ago

@qtomlinson Do you think you might have time to carry this forward while I'm on vacation? I think that would be tremendously helpful! 🙏🏼

qtomlinson commented 4 months ago

@lumaxis sounds good. The merge/flatten/expandmethods in @clearlydefined/spdx do not help us here. I have updated the PR based on what we discussed during the dev sync meeting. Please review and provide feedback. I can also rebase this PR after the ScanCode upgrade PRs are merged.