fix: deploy falsely reports SUCCESS when it failed - Githubissues

clearlydefined / service

The service side of clearlydefined.io

MIT License

45 stars 39 forks source link

fix: deploy falsely reports SUCCESS when it failed #1091

Closed elrayle closed 2 months ago

elrayle commented 2 months ago

Multiple issues are fixed in this PR:

If the webapp publish profile secret is empty, webapps-deploy v3 doesn’t deploy but reports the deploy as passing. See Azure/webapps-deploy Issue #404.
Configs were set before running the deploy. This means that the config values in Azure are updated even if the deploy fails.
The action was runnable by anyone with write access. That is too broad for production.

To avoid these known issues, the PR updates to...

check that all required secrets are set before proceeding
only update configs if the deploy passes
call the reusable workflow that checks if the user has access to deploy

elrayle commented 2 months ago

This is superseded by the work in:

The new PRs combine the dev and deploy workflows into a single shared workflow in operations.