search

clearlydefined / service

The service side of clearlydefined.io
MIT License
45 stars 40 forks source link

Deprecated SPDX license identifiers #579

Open ariel11 opened 5 years ago

ariel11 commented 5 years ago

We should decide if we want the deprecated license identifiers in the license drop down menu in ClearlyDefined - e.g. GPL-2.0, LGPL-3.0, etc. (see https://spdx.org/licenses/index.html).

ariel11 commented 5 years ago

@pombredanne , @royaljust - FYI

jeffmendoza commented 4 years ago

The license list shown in the websites' dropdown is likely from the service. Fix dropdown list first, then figure out how to migrate old definitions.

capfei commented 4 years ago

@jeffmendoza and @MichaelTsengLZ - any update with this? I still get a quite a lot curations using deprecated identifiers and it eats up a lot of time fixing them.

jeffmendoza commented 4 years ago

Are the curations coming from the Website, or from "Microsoft Automation"?

capfei commented 4 years ago

Both, but right now, mainly from automation.

jeffmendoza commented 4 years ago

I'll create a Microsoft bug for the ones from automation. This bug can stay here, referring to curations from the website.

nellshamrell commented 3 years ago

Hi @capfei! Could you link me to a few recent curations where you are seeing this? It will help a lot with giving me the context to diagnose and fix this issue.

capfei commented 3 years ago

@nellshamrell Here are some that I have had to update within the last month or so:

LGPL-3.0: https://github.com/clearlydefined/curated-data/pull/8357 LGPL-2.1+: https://github.com/clearlydefined/curated-data/pull/8346 GPL-2.0-with-classpath-exception: https://github.com/clearlydefined/curated-data/pull/8361 GPL-3.0: https://github.com/clearlydefined/curated-data/pull/8301

ariel11 commented 3 years ago

@nellshamrell and @jeffmendoza - Yes, seeing this too -e.g. LGPL-2.1+ from the automation tooling - https://github.com/clearlydefined/curated-data/pull/6287

nellshamrell commented 3 years ago

It looks like all of those examples came from Microsoft tooling, which I know @jeffmendoza has opened an internal Microsoft bug for.

Has anyone seen this happen from curations from the website?

capfei commented 3 years ago

I can probably find some older ones, but we don't receive many curations from the website. The deprecated licenses are in the license list on the website.

My screenshot shows some of the deprecated licenses. image

capfei commented 3 years ago

https://github.com/clearlydefined/curated-data/pull/6044/commits/a5a6fbe837456a209f70915033d55b270dff5313 https://github.com/clearlydefined/curated-data/pull/4785/commits/d94ddf2610fd8cdd82ea7a63c594381aff6a5f75

nellshamrell commented 3 years ago

Thank you! Looks like we need to at least remove the deprecated licenses from the list on the website.