search

clearlydefined / service

The service side of clearlydefined.io
MIT License
45 stars 40 forks source link

Highlight what triggered NOASSERTION #656

Open ariel11 opened 5 years ago

ariel11 commented 5 years ago

For files within a component that are marked as NOASSERTION, highlight in the file what the tooling thinks may be license info. Otherwise, I am scanning some really long files trying to find why the tooling thought maybe there was license info on that file.

storrisi commented 5 years ago

@ariel11 I think that your requirement is covered by the Suggestions behavior. In that case, the UI shows the same value for each field that has been curated in other versions of the same component.

Otherwise, i don't know a way that the tool could use to provide some suggested values.

Thoughts?

ariel11 commented 5 years ago

@storrisi - I am not sure if we are talking about the same thing. For example, if you go to pytest-pycharm/fc38a5207039ef0cf193e9925a5ca8c1e28d1abf, you will see files that say "NOASSERTION" (like the setup.py file). It would be awesome to have surfaced somehow what the scanners caught on that file that made it flag it as NOASSERTION. For the setup.py file, for example, I see on row 24 and row 30, a reference to "BSD" and "License." But I am just visually scanning these NOASSERTION files looking for why the scanners flagged it as that. Since the scanners are flagging it as NOASSERTION for a reason, it would be really handy to have visibility into what words triggered the NOASSERTION flag.

ariel11 commented 5 years ago

@royaljust as FYI

bduranc commented 5 years ago

+1 to @ariel11's suggestion

storrisi commented 5 years ago

@geneh do you think that the service could in someway return these details to the UI, even with a separate API?

geneh commented 5 years ago

@storrisi Possibly, it's worth exploring.