search

clearmatics / libff

C++ library for Finite Fields and Elliptic Curves (forked from scipr-lab/libff)
https://clearmatics.github.io/libff/
Other
3 stars 2 forks source link

Group membership checks #28

Closed dtebbs closed 3 years ago

dtebbs commented 4 years ago

Safe subgroup membership check methods. These methods are generic, relying on large scalar multiplications. More optimal per-curve checks may be added in a future PR.

AntoineRondelet commented 4 years ago

Related to: https://github.com/clearmatics/libff/issues/16

dtebbs commented 4 years ago

It could be problematic to do these checks by default when deserializing. At least with the naive versions here. Deserialising anything sizable is unfeasible, so we may have to default to no checks and add read_*_safe functions as per the original description.

dtebbs commented 3 years ago

Updated this PR to include only the addition of the (unoptimized) is_in_safe_subgroup. Performing these checks on load can be addressed as part of another PR.