clearmatics / zecale

General purpose aggregator using recursive composition of SNARKs: https://arxiv.org/abs/2008.05958
https://clearmatics.github.io/zecale
GNU Lesser General Public License v3.0
8 stars 3 forks source link

Build nested gadgets/sub-circuits consistently #23

Open AntoineRondelet opened 4 years ago

AntoineRondelet commented 4 years ago

As mentioned in https://github.com/clearmatics/zecale/pull/19#discussion_r460721638 let's be consistent with how nested gadgets are instantiated.

dtebbs commented 4 years ago

I would be in favour of simply avoiding shared_ptr unless absolutely necessary. The disadvantages I see in using it where not strictly necessary are:

In may cases, we need to use pointers of some kind. shared_ptr may sometimes be the right solution, although there are cases where another type might be safer (especially where the sub-gadget is intended to be internal to the gadget that creates it).