clearmatics / zecale

General purpose aggregator using recursive composition of SNARKs: https://arxiv.org/abs/2008.05958
https://clearmatics.github.io/zecale
GNU Lesser General Public License v3.0
8 stars 3 forks source link

Fix gadget inheritances inconsistencies #98

Open AntoineRondelet opened 2 years ago

AntoineRondelet commented 2 years ago

So far, we have followed a "public inheritance" approach when inheriting from the libsnark::gadget class and set the right scopes on the class' attributes and methods. However, the aggregator_gadget inherits privately from gadget which contrasts with the approach just mentioned (following public inheritance), see: https://clearmatics.github.io/zecale/inherits.html for illustration. This inconsistency needs to either: