clearpathrobotics / occupancy_grid_utils

Forked from https://kforge.ros.org/gridutils/git with Catkinizing changes. The package contains utilities for dealing with occupancy grids, represented as nav_msgs::OccupancyGrid objects, including coordinate conversions, shortest paths, ray tracing, and constructing from laser scans.

42 stars 48 forks source link

Changed OpenCV dependency to 'cv_bridge' to work on hydro and indigo #5

Closed jjekircp closed 9 years ago

jjekircp commented 9 years ago

I'd like to be able to bloom this package for both hydro and indigo, and I ran into an issue where "opencv2" is not a valid rosdep key for trusty/indigo: $ rosdep resolve --rosdistro hydro --os=ubuntu:precise opencv2

apt

ros-hydro-opencv2 $ rosdep resolve --rosdistro indigo --os=ubuntu:trusty opencv2 ERROR: no rosdep rule for 'opencv2'

Looking at the ROS wiki page for opencv2, I'm referred to the cv_bridge package. Changing the build_depend and run_depend to cv_bridge results in a successful rosdep resolution and build on a fresh Precise/Hydro as well as a fresh Trusty/Indigo system.

paulbovbel commented 9 years ago

libopencv-dev is the key you're looking for (https://github.com/ros/rosdistro/blob/f4af6fb00c004711573d7f74e6ba662f20030459/rosdep/base.yaml#L1547)

mikepurvis commented 9 years ago

If you want Hydro and Indigo compatibility, it's not that straightforward:

http://answers.ros.org/question/185105/add-opencv-to-indigo/?answer=185220#post-id-185220

I think cv_bridge is the correct dependency as long as you're supporting both from a common codebase.

jjekircp commented 9 years ago

Looking through https://github.com/ros/rosdistro/issues/4722 and http://wiki.ros.org/indigo/Migration#OpenCV (as linked from that answers.ros.org question) there seems to be a solid case for using cv_bridge.

Is this ok to merge?

mikepurvis commented 9 years ago