search

clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
193 stars 96 forks source link

Updated install script to allow adding multiple launch files to a job #28

Closed jjekircp closed 8 years ago

jjekircp commented 9 years ago

Adjusted argparse to accept multiple pkgpath arguments and changed the code to loop over the resulting list and add each entry to the Job object.

Proposed to make the install script more convenient for users who wish to install several launch files all at once with one command.

I regenerated the documentation locally and it automatically updated to reflect this change, so I don't believe any manual changes are necessary. I am happy to make any changes if necessary though.

I would also like to have this change backported to Indigo. I'm assuming the usual procedure is to make the change on the jade-devel branch and then backport.

jjekircp commented 9 years ago

@mikepurvis Any other comments?

mikepurvis commented 8 years ago

Looks good, thanks. Sorry this fell of my radar.

mikepurvis commented 8 years ago

Backported to indigo in cd217fba8f9d53c304ef579a2ad0c75136b99300.

Released: https://github.com/ros/rosdistro/pull/9906