search

clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
196 stars 96 forks source link

Updated docs for systemd #65

Closed dniewinski closed 6 years ago

130s commented 6 years ago

You're replacing service with systemctrl. Can you elaborate why this change makes sense? I'm not a super expert in Linux, so tried to understand looking at pages like this but I'm just not yet sure if this is an improvement.

mikepurvis commented 6 years ago

This looks reasonable to me, but we should probably put this on a new kinetic-devel branch, and then call out that systemctl is systemd-specific, and refer users to Indigo documentation for the Upstart details.

(Or refactor the whole thing to supply usage documentation alongside the individual plugins...)

dniewinski commented 6 years ago

@130s Ubuntu is changing over from service to systemd in the long-term. Currently both are supported, but that will change.

mikepurvis commented 6 years ago

Well, usr/sbin/service is still part of at least Ubuntu Bionic, see: https://packages.ubuntu.com/bionic/all/init-system-helpers/filelist

I'd be kind of surprised if they ever actually removed it, given that it's the common CLI between init systems— whether you're on systemd, upstart, sysvinit.

dniewinski commented 6 years ago

I will make a new kinetic-devel branch and store this there. I'll also make the suggested changed by @paulbovbel