clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.

BSD 3-Clause "New" or "Revised" License

193 stars 96 forks source link

[doc] Clarify the logic for automated job name determination. #82

Closed 130s closed 5 years ago

130s commented 5 years ago

Problem addressed

When --job option is not passed to rosrun robot_upstart install, the job name gets determined automatically but the logic of it is not clear.

Solution to the problem

Add an explanation to the document.

mikepurvis commented 5 years ago

Thanks!

borgcons commented 4 years ago

Why is the job name truncated?

jobname = args.job or pkg.split("",1)[0]

130s commented 4 years ago

@borgcons I think that's a fair question. However this PR is probably not the right place to discuss that. I think either opening a ticket or pull request will work to facilitate conversation.

borgcons commented 4 years ago

@130s You mean open an issue #80