clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
192 stars 94 forks source link

Change systemd dependency to network-online.target #93

Closed kledom closed 4 years ago

kledom commented 4 years ago

On current systems, ordering after network.target just guarantees that the network service has been started, not that there's some actual configuration.

mikepurvis commented 4 years ago

This seems reasonable; my main concern with it is that I don't want robot startup delayed until after the wifi is connected— it should happen as soon as static IPs are assigned. Looking at the documentation for this from systemd, it's not really clear to me what the expected behavior is:

https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

Can you clarify?