clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.
BSD 3-Clause "New" or "Revised" License
193 stars 96 forks source link

Release for Noetic Ubuntu 20.04 #94

Closed Crowdedlight closed 3 years ago

Crowdedlight commented 4 years ago

We are currently using your package as a great way to ensure our ros system starts upon boot. However we are currently moving to the new Noetic release, and noticed that there is no released ros-noetic-robot-upstart package.

I can see there is a noetic branch. Whats is the timeline for getting a noetic version released?

Can I manually compile and use it, by just adding the noetic branch files in a catkin_ws and build it? Or is there additional steps required?

mikaelarguedas commented 4 years ago

+1 a python3 version released in ROS Noetic would be awesome

mmmherma commented 4 years ago

Hello everyone:

Trying to use this node in Ubuntu 20 I have the following issue when running rosrun robot_upstart install --job soar soar_gui/launch/soar_gui.launch:

Traceback (most recent call last): File "/home/aeorum/catkin_ws/devel/lib/robot_upstart/install", line 15, in <module> exec(compile(fh.read(), python_script, 'exec'), context) File "/home/aeorum/catkin_ws/src/soar/robot_upstart/scripts/install", line 29, in <module> from robot_upstart.install_script import main File "/home/aeorum/catkin_ws/devel/lib/python3/dist-packages/robot_upstart/__init__.py", line 34, in <module> exec(__fh.read()) File "<string>", line 24, in <module> ModuleNotFoundError: No module named 'job'

Does anybody experienced this problem?

Thank you in advance.

mikaelarguedas commented 4 years ago

This package has not been fully ported to python 3 yet. You can try https://github.com/clearpathrobotics/robot_upstart/pull/96 that provides a python 3 port

mmmherma commented 4 years ago

It worked like a charm! :)

Thank you very much!

JJBUT commented 3 years ago

Is there any other reason that the current noetic branch would produce this error on 20? Currently I am getting the same error, in <module> exec(__fh.read()) File "<string>", line 24, in <module> ModuleNotFoundError: No module named 'job' And I am unable to solve it using the current branch. Is there something else that is going wrong on my end?

mikaelarguedas commented 3 years ago

The noetic branch is not compatible with Python 3 at the moment. You can try the branch from #96 that provides a python 3 port

mikaelarguedas commented 3 years ago

The PR mentionned above has been merged and a new version in Noetic has been released. So I think this issue can be closed