[noetic-devel] python3 compatibility + green CI on ROS noetic

clearpathrobotics / robot_upstart

ROS package of helper functions related to bringing up roslaunch on system startup.

BSD 3-Clause "New" or "Revised" License

192 stars 94 forks source link

[noetic-devel] python3 compatibility + green CI on ROS noetic #98

Closed mikaelarguedas closed 3 years ago

mikaelarguedas commented 3 years ago

Goes along https://github.com/clearpathrobotics/robot_upstart/pull/96

Uses the Python3 compatibility fixes from #96 and adds noetic CI configuration + fixes the roslint errors reported

mikaelarguedas commented 3 years ago

Now part of #96

mikaelarguedas commented 3 years ago

This PR build upon #96 and fixes the issues to get green ci. @mikepurvis would this be sufficient for an initial noetic release ? or are there other points to address to have a noetic deb of this package (happy to help if needed)

civerachb-cpr commented 3 years ago

This looks good to me. I've tested it in a VM with Noetic and it appears to work as-desired. @mikepurvis since you're the maintainer of this package I've requested your review.

mikepurvis commented 3 years ago

Looks great— sorry for the long silence here. @civerachb-cpr, @tonybaltovski please feel free to take over the formal maintainership of this repo, as we haven't used it for some time on the OTTO platforms.