search

clearwater / SwitecX25

Arduino library for Switec X25.168 and friends
http://clearwater.github.com/gaugette/
Other
128 stars 44 forks source link

Setting pin 13 to output in x12 #23

Closed AlessandroEmm closed 11 months ago

AlessandroEmm commented 1 year ago

Hey there

Is there a particular reason this is https://github.com/clearwater/SwitecX25/blob/67ace428cedab342c1bcb1024f4ad0884cf0ccb0/SwitecX12.cpp#L38 in?

I'm surprised none has mentioned it before. :-)

Thanks, Alessandro

guyc commented 1 year ago

Hah, that's funny. I looked back at the original experimental code this was derived from at https://guy.carpenter.id.au/gaugette/2017/04/29/switecx25-quad-driver-tests/ and it looks like I had an LED on pin 13 showing the drive direction. It should not be there in the library. I'll fix that.

guyc commented 11 months ago

Line removed. Thanks Alessandro.