1.0.0 beta 1 - Githubissues

cleder commented 4 weeks ago

User description

PR Type

Enhancement, Tests, Documentation

Description

Added new utility functions for handling KML attributes and elements, improving code clarity and functionality.
Refactored geometry classes and enhanced handling of KML attributes, including extrude and tessellate attributes.
Introduced a new module for validating KML files against XML schema.
Updated Sphinx configuration and added new example scripts for documentation purposes.
Added extensive tests, including property-based tests using Hypothesis, to improve test coverage and reliability.
Updated various tests to use from_string method for consistency and improved error handling.

Changes walkthrough 📝

Relevant files

Enhancement

17 files

helpers.py `Add utility functions for KML attribute handling` fastkml/helpers.py Added new utility functions for handling KML attributes and elements. Introduced functions for extracting and setting datetime and coordinate values. Enhanced verbosity handling in attribute value retrieval. Improved type hinting and imports for better code clarity.	+354/-91
geometry.py `Refactor geometry classes and improve attribute handling` fastkml/geometry.py Refactored geometry classes to improve handling of KML attributes. Removed redundant registry entries and attributes. Enhanced equality checks for geometry classes. Improved handling of extrude and tessellate attributes.	+287/-260
gx.py `Refactor and enhance Track and TrackItem classes for XML handling` fastkml/gx.py Removed unused imports and added new ones. Refactored `TrackItem` class to remove XML element generation. Updated `Track` class to handle `whens`, `coords`, and `angles` properties. Registered `Track` class with new registry items for XML serialization.	+138/-297
times.py `Enhance time handling with registry-based XML serialization` fastkml/times.py Added detailed module-level docstring. Registered `TimeStamp` and `TimeSpan` with new registry items for XML handling. Removed custom XML element creation methods.	+62/-106
views.py `Set default values and update altitude mode in views.` fastkml/views.py Added `default` values to several registry items. Changed `altitude_mode` default to `None` in `Camera` and `LookAt` classes. Added a link to the Camera documentation.	+32/-14
enums.py `Update Verbosity and AltitudeMode enums with new method.` fastkml/enums.py Changed `quiet` to `terse` in `Verbosity` enum. Reformatted `AltitudeMode` docstring for better readability. Added `get_ns_id` method to `AltitudeMode`.	+42/-32
overlays.py `Set default values for overlay registry items.` fastkml/overlays.py - Added `default` values to several registry items.	+16/-0
links.py `Update Link class attributes and registry defaults.` fastkml/links.py Changed `href`, `view_format`, and `http_query` to non-optional with default values. Added `default` values to several registry items.	+42/-36
styles.py `Set default values for style registry items.` fastkml/styles.py Added `default` values to several registry items. Changed `color` to have a default value in `_ColorStyle`.	+16/-2
validator.py `Add KML validation module with schema parsing.` fastkml/validator.py Introduced a new module for validating KML files against XML schema. Added functions for schema parsing and validation.	+114/-0
features.py `Set default values and update geometry creation in features.` fastkml/features.py Added `default` values to several registry items. Updated `create_kml_geometry` assignment in `Placemark`.	+14/-8
atom.py `Update Atom classes to use non-optional attributes.` fastkml/atom.py Changed `href`, `rel`, `type`, `hreflang`, `title`, `name`, `uri`, and `email` to non-optional with default values.	+17/-18
utils.py `Add utility functions for attribute checking and searching.` fastkml/utils.py Introduced utility functions `find_all` and `has_attribute_values`.	+91/-0
registry.py `Simplify registry item types and add default attribute.` fastkml/registry.py Removed `known_types` union type. Added `default` attribute to `RegistryItem`.	+5/-15
__init__.py `Update module imports and add new utilities.` fastkml/__init__.py Updated imports to include new classes and utilities. Renamed some imports for consistency.	+19/-5
data.py `Reorder registry items for SimpleField and Data.` fastkml/data.py - Reordered registry items for `SimpleField` and `Data`.	+17/-18
containers.py `Use utility function for style retrieval in containers.` fastkml/containers.py - Used `find_all` utility function in `get_style_by_url` method.	+9/-1

Tests

32 files

gx_test.py `Update and enhance tests for Track and MultiTrack classes` tests/gx_test.py Updated tests for `Track` and `MultiTrack` classes. Added tests for new functionality in `Track` class. Improved test coverage for KML datetime handling. Refactored test cases for better clarity and coverage.	+260/-206
multi_geometry_test.py `Add property-based tests for MultiGeometry class` tests/hypothesis/multi_geometry_test.py Added property-based tests for `MultiGeometry` class. Utilized hypothesis strategies for generating test cases. Ensured round-trip consistency for string representations. Validated XML elements generated from geometries.	+704/-0
geometry_test.py `Introduce property-based tests for geometry classes` tests/hypothesis/geometry_test.py Introduced property-based tests for geometry classes. Tested round-trip consistency for string and repr representations. Validated XML elements for various geometry types. Utilized hypothesis strategies for comprehensive test coverage.	+484/-0
geometry_test.py `Update geometry tests and remove deprecated attributes` tests/geometries/geometry_test.py Updated copyright year. Replaced `class_from_string` with `from_string` in tests. Removed tests for `extrude` and `tessellate` attributes. Added assertions for geometry presence.	+77/-107
kml_test.py `Enhance KML parsing tests with new cases and methods` tests/kml_test.py Replaced `class_from_string` with `from_string` in tests. Added new tests for KML parsing and serialization. Added test for parsing KML with `None` namespace.	+371/-4
times_test.py `Improve datetime parsing tests and update methods` tests/times_test.py Updated copyright year. Replaced `class_from_string` with `from_string` in tests. Added assertions for datetime parsing and handling. Improved exception handling in datetime tests.	+62/-26
multigeometry_test.py `Add verbosity tests and handle GeometryError in MultiGeometry` tests/geometries/multigeometry_test.py Added new tests for verbosity in `MultiGeometry`. Replaced `class_from_string` with `from_string`. Added tests for `GeometryError`.	+66/-22
point_test.py `Extend Point tests with verbosity and error handling` tests/geometries/point_test.py Added tests for verbosity in `Point`. Replaced `class_from_string` with `from_string`. Added tests for `GeometryError`.	+96/-26
utils_test.py `Add utility function tests for find and find_all` tests/utils_test.py Added new tests for `find` and `find_all` utility functions. Tested schema retrieval by URL.	+215/-0
styles_test.py `Update style tests and add usage scenarios` tests/styles_test.py Replaced `class_from_string` with `from_string`. Added tests for style creation and usage in documents and placemarks. Tested `StyleMap` handling of `None` cases.	+88/-10
polygon_test.py `Enhance Polygon tests with verbosity and error handling` tests/geometries/polygon_test.py Added tests for verbosity in `Polygon`. Replaced `class_from_string` with `from_string`. Added tests for `GeometryError`.	+86/-10
linestring_test.py `Enhance LineString tests with error handling and verbosity checks.` tests/geometries/linestring_test.py Added imports for `exceptions`, `Verbosity`, `GeometryError`, and `Coordinates`. Introduced `test_geometry_error` to test `GeometryError` exception. Replaced `class_from_string` with `from_string` in several test methods. Added tests for `from_string` method with invalid extrude and tessellate values. Added tests for `to_string` method with different verbosity levels.	+90/-9
overlays_test.py Update GroundOverlay and PhotoOverlay tests for `from_string` method. tests/overlays_test.py Replaced `class_from_string` with `from_string` in multiple test methods. Added assertions for `view_volume` and `image_pyramid` in `test_create_photo_overlay_with_all_optional_parameters`.	+16/-14
gx_test.py `Add Hypothesis tests for gx Track and MultiTrack.` tests/hypothesis/gx_test.py Introduced a new test file for `gx` Track and MultiTrack using Hypothesis. Added property-based tests for `Track` and `MultiTrack` classes.	+141/-0
boundaries_test.py `Add GeometryError tests and update boundary string methods.` tests/geometries/boundaries_test.py Added imports for `Type`, `Union`, and `pytest`. Introduced tests for `GeometryError` in boundary classes. Replaced `class_from_string` with `from_string` in several test methods.	+47/-4
helper_test.py `Add tests for helper functions edge cases.` tests/helper_test.py Introduced a new test file for helper functions. Added tests for various helper functions like `subelement_int_kwarg` and `attribute_float_kwarg`.	+147/-0
containers_test.py `Update container tests and add style retrieval tests.` tests/containers_test.py Replaced `class_from_string` with `from_string` in several test methods. Added tests for container creation and feature append methods. Added tests for `get_style_by_url` method in Document.	+93/-3
data_test.py `Update data tests to use from_string method.` tests/data_test.py Replaced `class_from_string` with `from_string` in several test methods.	+11/-11
common.py `Add common utilities for property-based tests.` tests/hypothesis/common.py Introduced a new module for common functionality in property-based tests. Added functions for testing repr and string roundtrip.	+107/-0
links_test.py `Add Hypothesis tests for Link and Icon classes.` tests/hypothesis/links_test.py Introduced a new test file for Link and Icon using Hypothesis. Added property-based tests for `Link` and `Icon` classes.	+101/-0
atom_test.py `Update atom tests to use from_string method.` tests/atom_test.py Replaced `class_from_string` with `from_string` in several test methods. Updated tests for `Link` and `Author` classes.	+10/-10
validator_test.py `Add tests for KML validator module.` tests/validator_test.py Introduced a new test file for the validator module. Added tests for validating KML files and elements.	+108/-0
linearring_test.py `Update LinearRing tests to use from_string method.` tests/geometries/linearring_test.py Replaced `class_from_string` with `from_string` in several test methods.	+7/-6
atom_test.py `Add Hypothesis tests for Atom Link and Author.` tests/hypothesis/atom_test.py Introduced a new test file for Atom classes using Hypothesis. Added property-based tests for `Link` and `Author` classes.	+91/-0
base_test.py `Update base tests to use from_string method.` tests/base_test.py Replaced `class_from_string` with `from_string` in several test methods.	+7/-7
functions_test.py `Add tests for geometry error handling functions.` tests/geometries/functions_test.py Introduced a new test file for geometry functions. Added tests for error handling in geometry functions.	+88/-0
strategies.py `Add custom hypothesis strategies for testing.` tests/hypothesis/strategies.py Introduced custom hypothesis strategies for testing. Added strategies for generating XML text, media types, and query strings.	+60/-0
coordinates_test.py `Update Coordinates tests to use from_string method.` tests/geometries/coordinates_test.py Replaced `class_from_string` with `from_string` in several test methods.	+3/-3
features_test.py `Update features tests with improved error assertions.` tests/features_test.py Added a match argument to the `ValueError` assertion in `test_placemark_geometry_and_kml_geometry_parameter_set`. Replaced `class_from_string` with `from_string` in `test_network_link_read`.	+7/-3
views_test.py `Update views tests to use from_string method.` tests/views_test.py Replaced `class_from_string` with `from_string` in several test methods. Added boolean assertion for `Region` in `test_region_with_all_optional_parameters`.	+4/-3
links_test.py `Update links tests to use from_string method.` tests/links_test.py Replaced `class_from_string` with `from_string` in several test methods.	+3/-3
registry_test.py `Simplify registry test types and update functions.` tests/registry_test.py Removed `known_types` union type. Added `default` parameter to `set_element` and `get_kwarg` functions.	+2/-11

Documentation

5 files

conf.py `Update Sphinx configuration for enhanced documentation` docs/conf.py Updated Sphinx configuration for documentation generation. Added new extensions for autosummary and viewcode. Adjusted versioning information for documentation. Enhanced documentation build settings.	+6/-2
Document-clean.kml `Add reference to KML document in documentation` docs/Document-clean.kml - Added reference to a KML document for documentation purposes.	+1/-0
shp2kml_timed.py `Add example script for shapefile to KML conversion with time.` examples/shp2kml_timed.py Introduced a new example script for converting shapefiles to KML with time data. Utilized `fastkml` to create KML with CO2 growth data.	+92/-0
shp2kml.py `Add example script for shapefile to KML conversion.` examples/shp2kml.py Introduced a new example script for converting shapefiles to KML. Utilized `fastkml` to create KML with CO2 data.	+72/-0
transform_cascading_style.py `Add example script for transforming cascading styles in KML.` examples/transform_cascading_style.py Introduced a new example script for transforming cascading styles in KML. Demonstrated usage of `CascadingStyle` and `Document` classes.	+80/-0

Configuration changes

1 files

ne_110m_admin_0_countries.cpg

Add character encoding specification file.

examples/ne_110m_admin_0_countries.cpg - Added a new file for character encoding specification.

+1/-0

Additional files (token-limit)

29 files

base.py `...` fastkml/base.py ...	+3/-5
base.py `...` tests/base.py ...	+6/-4
simple_example.py `...` examples/simple_example.py ...	+6/-4
conftest.py `...` tests/conftest.py ...	+21/-0
kml.py `...` fastkml/kml.py ...	+1/-3
about.py `...` fastkml/about.py ...	+1/-1
repr_eq_test.py `...` tests/repr_eq_test.py ...	+1/-1
read_kml.py `...` examples/read_kml.py ...	+1/-1
config_test.py `...` tests/config_test.py ...	+1/-1
xAL.xsd `...` fastkml/schema/xAL.xsd ...	+1680/-0
ne_110m_admin_0_countries.README.html `...` examples/ne_110m_admin_0_countries.README.html ...	+547/-0
kml22gx.xsd `...` fastkml/schema/kml22gx.xsd ...	+329/-0
working_with_kml.rst `...` docs/working_with_kml.rst ...	+238/-0
create_kml_files.rst `...` docs/create_kml_files.rst ...	+233/-0
quickstart.rst `...` docs/quickstart.rst ...	+201/-4
run-all-tests.yml `...` .github/workflows/run-all-tests.yml ...	+69/-31
pyproject.toml `...` pyproject.toml ...	+38/-70
.pre-commit-config.yaml `...` .pre-commit-config.yaml ...	+18/-23
gx_cascading_style.kml `...` examples/gx_cascading_style.kml ...	+93/-0
fastkml.rst `...` docs/fastkml.rst ...	+62/-10
README.rst `...` README.rst ...	+9/-15
atom-author-link.xsd `...` fastkml/schema/atom-author-link.xsd ...	+66/-0
index.rst `...` docs/index.rst ...	+9/-20
configuration.rst `...` docs/configuration.rst ...	+43/-1
alternatives.rst `...` docs/alternatives.rst ...	+19/-0
ogckml22.xsd `...` fastkml/schema/ogckml22.xsd ...	+6/-1
README.md `...` examples/README.md ...	+12/-2
Document-places.kml `...` tests/ogc_conformance/data/kml/Document-places.kml ...	+2/-2
ne_110m_admin_0_countries.prj `...` examples/ne_110m_admin_0_countries.prj ...	+1/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Summary by CodeRabbit

New Features
- Enhanced testing capabilities with new property-based tests for various classes using Hypothesis.
- Introduced validation functionality for KML files against XML schemas.
- Added support for new KML structures and improved error handling in existing functionalities.
Bug Fixes
- Updated method calls to reflect changes in the API, ensuring consistent instantiation of KML objects.
- Enhanced error messages for clarity and improved error handling in geometry-related tests.
Documentation
- Improved README and documentation files for clarity and completeness.
- Added comprehensive guides for creating and reading KML files.
Chores
- Updated dependencies in the project configuration.
- Cleaned up and restructured test cases for better organization and coverage.

sourcery-ai[bot] commented 4 weeks ago

Reviewer's Guide by Sourcery

This pull request implements significant refactoring and improvements to the FastKML library, focusing on code quality, testing, and validation. The changes include improved type hints, better error handling, enhanced test coverage using property-based testing, XML schema validation, and standardized code formatting.

Updated class diagram for the Geometry classes

classDiagram
    class _Geometry {
        -altitude_mode: Optional[AltitudeMode]
        +__init__(...)
        +__repr__() str
    }

    class Point {
        +extrude: Optional[bool]
        +kml_coordinates: Optional[Coordinates]
        +__init__(...)
        +__eq__(other: object) bool
    }

    class LineString {
        +extrude: Optional[bool]
        +tessellate: Optional[bool]
        +kml_coordinates: Optional[Coordinates]
        +__init__(...)
        +__eq__(other: object) bool
    }

    class Polygon {
        +extrude: Optional[bool]
        +tessellate: Optional[bool]
        +outer_boundary: Optional[OuterBoundaryIs]
        +inner_boundaries: List[InnerBoundaryIs]
        +__init__(...)
        +__eq__(other: object) bool
    }

    class MultiGeometry {
        +kml_geometries: List[Union[Point, LineString, Polygon, LinearRing, Self]]
        +__init__(...)
    }

    _Geometry <|-- Point
    _Geometry <|-- LineString
    _Geometry <|-- Polygon
    _BaseObject <|-- MultiGeometry

Updated class diagram for the Boundary classes

classDiagram
    class BoundaryIs {
        +geometry: Optional[geo.LinearRing]
    }

    class OuterBoundaryIs {
        +get_tag_name() str
    }

    class InnerBoundaryIs {
        +get_tag_name() str
    }

    BoundaryIs <|-- OuterBoundaryIs
    BoundaryIs <|-- InnerBoundaryIs

Updated class diagram for the Track and MultiTrack classes

classDiagram
    class Track {
        +track_items: List[TrackItem]
        +whens: Tuple[KmlDateTime, ...]
        +coords: Tuple[PointType, ...]
        +angles: Tuple[PointType, ...]
        +__init__(...)
        +__bool__() bool
    }

    class MultiTrack {
        +tracks: List[Track]
        +interpolate: Optional[bool]
        +__init__(...)
    }

    Track <|-- MultiTrack

Updated class diagram for the Time classes

classDiagram
    class TimeStamp {
        +timestamp: Optional[KmlDateTime]
    }

    class TimeSpan {
        +begin: Optional[KmlDateTime]
        +end: Optional[KmlDateTime]
    }

    _TimePrimitive <|-- TimeStamp
    _TimePrimitive <|-- TimeSpan

File-Level Changes

Change	Details	Files
Refactored geometry handling and validation	Added XML schema validation against OGC KML 2.2 schema Improved geometry type handling and conversions Added support for default values in geometry attributes Standardized handling of coordinate precision and verbosity levels	`fastkml/geometry.py` `fastkml/validator.py` `tests/geometries/geometry_test.py`
Enhanced testing infrastructure with property-based testing	Added Hypothesis-based property testing for geometry classes Implemented comprehensive roundtrip testing for XML serialization Added test helpers for common validation patterns Increased test coverage requirements to 95%	`tests/hypothesis/geometry_test.py` `tests/hypothesis/multi_geometry_test.py` `tests/hypothesis/common.py` `.github/workflows/run-all-tests.yml`
Improved type hints and code quality	Added proper type hints throughout the codebase Standardized error handling patterns Improved documentation and docstrings Added stricter linting rules and formatting checks	`pyproject.toml` `.pre-commit-config.yaml` `fastkml/helpers.py` `fastkml/registry.py`
Refactored GX extension support	Improved Track and MultiTrack implementations Added proper timezone handling for KML timestamps Enhanced coordinate handling in GX elements Added property-based tests for GX elements	`fastkml/gx.py` `tests/hypothesis/gx_test.py`

Tips and commands

#### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).

semanticdiff-com[bot] commented 4 weeks ago

Review changes with

Changed Files

| File | Status | | :--- | :--- | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/enums.py) [fastkml/enums\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/enums.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/enums.py) 85% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/data.py) [fastkml/data\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/data.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/data.py) 84% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/links.py) [fastkml/links\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/links.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/links.py) 82% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/features_test.py) [tests/features\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/features_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/features_test.py) 65% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/config_test.py) [tests/config\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/config_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/config_test.py) 57% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/gx_test.py) [tests/gx\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/gx_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/gx_test.py) 41% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/simple_example.py) [examples/simple\_example\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/simple_example.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/simple_example.py) 39% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/base.py) [fastkml/base\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/base.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/base.py) 35% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/geometry.py) [fastkml/geometry\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/geometry.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/geometry.py) 35% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/atom.py) [fastkml/atom\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/atom.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/atom.py) 31% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/times_test.py) [tests/times\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/times_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/times_test.py) 29% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/geometry_test.py) [tests/geometries/geometry\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/geometry_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/geometry_test.py) 27% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/features.py) [fastkml/features\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/features.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/features.py) 20% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/__init__.py) [fastkml/\_\_init\_\_\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/__init__.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/__init__.py) 20% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/point_test.py) [tests/geometries/point\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/point_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/point_test.py) 18% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/views.py) [fastkml/views\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/views.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/views.py) 17% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/multigeometry_test.py) [tests/geometries/multigeometry\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/multigeometry_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/multigeometry_test.py) 14% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/registry.py) [fastkml/registry\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/registry.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/registry.py) 12% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linearring_test.py) [tests/geometries/linearring\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linearring_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linearring_test.py) 10% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/styles.py) [fastkml/styles\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/styles.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/styles.py) 9% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/gx.py) [fastkml/gx\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/gx.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/gx.py) 9% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/times.py) [fastkml/times\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/times.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/times.py) 6% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base.py) [tests/base\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base.py) 1% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#.github/workflows/run-all-tests.yml) [\.github/workflows/run\-all\-tests\.yml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#.github/workflows/run-all-tests.yml) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#.pre-commit-config.yaml) [\.pre\-commit\-config\.yaml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#.pre-commit-config.yaml) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#README.rst) [README\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#README.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/Document-clean.kml) [docs/Document\-clean\.kml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/Document-clean.kml) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/Document-clean.kml) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/alternatives.rst) [docs/alternatives\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/alternatives.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/co2-per-capita-2020.jpg) [docs/co2\-per\-capita\-2020\.jpg](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/co2-per-capita-2020.jpg) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/conf.py) [docs/conf\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/conf.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/conf.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/configuration.rst) [docs/configuration\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/configuration.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/create_kml_files.rst) [docs/create\_kml\_files\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/create_kml_files.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/fastkml.rst) [docs/fastkml\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/fastkml.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/index.rst) [docs/index\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/index.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/installing.rst) [docs/installing\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/installing.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/modules.rst) [docs/modules\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/modules.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/quickstart.rst) [docs/quickstart\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/quickstart.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/reference_guide.rst) [docs/reference\_guide\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/reference_guide.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/usage_guide.rst) [docs/usage\_guide\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/usage_guide.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/working_with_kml.rst) [docs/working\_with\_kml\.rst](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#docs/working_with_kml.rst) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/CreateKml.py) [examples/CreateKml\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/CreateKml.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/CreateKml.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/README.md) [examples/README\.md](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/README.md) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/__init__.py) [examples/\_\_init\_\_\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/__init__.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/__init__.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/co2_per_capita.jpg) [examples/co2\_per\_capita\.jpg](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/co2_per_capita.jpg) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/gx_cascading_style.kml) [examples/gx\_cascading\_style\.kml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/gx_cascading_style.kml) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.README.html) [examples/ne\_110m\_admin\_0\_countries\.README\.html](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.README.html) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.cpg) [examples/ne\_110m\_admin\_0\_countries\.cpg](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.cpg) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.dbf) [examples/ne\_110m\_admin\_0\_countries\.dbf](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.dbf) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.prj) [examples/ne\_110m\_admin\_0\_countries\.prj](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.prj) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.shp) [examples/ne\_110m\_admin\_0\_countries\.shp](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.shp) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.shx) [examples/ne\_110m\_admin\_0\_countries\.shx](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/ne_110m_admin_0_countries.shx) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/owid-co2-data.csv) [examples/owid\-co2\-data\.csv](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/owid-co2-data.csv) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/read_kml.py) [examples/read\_kml\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/read_kml.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/read_kml.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml.py) [examples/shp2kml\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml_timed.py) [examples/shp2kml\_timed\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml_timed.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/shp2kml_timed.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/transform_cascading_style.py) [examples/transform\_cascading\_style\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/transform_cascading_style.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#examples/transform_cascading_style.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/about.py) [fastkml/about\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/about.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/about.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/containers.py) [fastkml/containers\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/containers.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/containers.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/helpers.py) [fastkml/helpers\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/helpers.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/helpers.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/kml.py) [fastkml/kml\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/kml.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/kml.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/overlays.py) [fastkml/overlays\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/overlays.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/overlays.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/atom-author-link.xsd) [fastkml/schema/atom\-author\-link\.xsd](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/atom-author-link.xsd) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/kml22gx.xsd) [fastkml/schema/kml22gx\.xsd](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/kml22gx.xsd) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/ogckml22.xsd) [fastkml/schema/ogckml22\.xsd](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/ogckml22.xsd) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/xAL.xsd) [fastkml/schema/xAL\.xsd](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/schema/xAL.xsd) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/utils.py) [fastkml/utils\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/utils.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/utils.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/validator.py) [fastkml/validator\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/validator.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#fastkml/validator.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#pyproject.toml) [pyproject\.toml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#pyproject.toml) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/atom_test.py) [tests/atom\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/atom_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/atom_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base_test.py) [tests/base\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/base_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/conftest.py) [tests/conftest\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/conftest.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/conftest.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/containers_test.py) [tests/containers\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/containers_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/containers_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/data_test.py) [tests/data\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/data_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/data_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/boundaries_test.py) [tests/geometries/boundaries\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/boundaries_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/boundaries_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/coordinates_test.py) [tests/geometries/coordinates\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/coordinates_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/coordinates_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/functions_test.py) [tests/geometries/functions\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/functions_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/functions_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linestring_test.py) [tests/geometries/linestring\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linestring_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/linestring_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/polygon_test.py) [tests/geometries/polygon\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/polygon_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/geometries/polygon_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/helper_test.py) [tests/helper\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/helper_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/helper_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/__init__.py) [tests/hypothesis/\_\_init\_\_\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/__init__.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/__init__.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/atom_test.py) [tests/hypothesis/atom\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/atom_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/atom_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/common.py) [tests/hypothesis/common\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/common.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/common.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/geometry_test.py) [tests/hypothesis/geometry\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/geometry_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/geometry_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/gx_test.py) [tests/hypothesis/gx\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/gx_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/gx_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/links_test.py) [tests/hypothesis/links\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/links_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/links_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/multi_geometry_test.py) [tests/hypothesis/multi\_geometry\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/multi_geometry_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/multi_geometry_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/strategies.py) [tests/hypothesis/strategies\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/strategies.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/hypothesis/strategies.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/kml_test.py) [tests/kml\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/kml_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/kml_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/links_test.py) [tests/links\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/links_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/links_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/ogc_conformance/data/kml/Document-places.kml) [tests/ogc\_conformance/data/kml/Document\-places\.kml](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/ogc_conformance/data/kml/Document-places.kml) | Unsupported file format | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/oldunit_test.py) [tests/oldunit\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/oldunit_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/oldunit_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/overlays_test.py) [tests/overlays\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/overlays_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/overlays_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/registry_test.py) [tests/registry\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/registry_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/registry_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/repr_eq_test.py) [tests/repr\_eq\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/repr_eq_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/repr_eq_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/styles_test.py) [tests/styles\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/styles_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/styles_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/utils_test.py) [tests/utils\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/utils_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/utils_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/validator_test.py) [tests/validator\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/validator_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/validator_test.py) 0% smaller | | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/views_test.py) [tests/views\_test\.py](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/views_test.py) | [

](https://app.semanticdiff.com/gh/cleder/fastkml/pull/377/changes#tests/views_test.py) 0% smaller |

coderabbitai[bot] commented 4 weeks ago

Walkthrough

The pull request introduces significant updates to the testing workflows and documentation within the FastKML project. Key changes include modifications to the GitHub Actions workflow for testing with updated Python versions, enhanced coverage thresholds, and the introduction of new jobs for building and publishing packages. The documentation has been reorganized and expanded, with new files for KML examples and detailed guides on creating KML files. Additionally, numerous tests have been added or updated to reflect changes in the library's API, ensuring comprehensive validation of KML functionalities.

Changes

File/Directory	Change Summary
`.github/workflows/run-all-tests.yml`	Updated Python version matrix, increased coverage threshold, added new jobs for building and testing packages.
`.pre-commit-config.yaml`	Updated repository and hook versions, added new hooks, and modified exclusion patterns.
`README.rst`	Enhanced documentation, added references to KML clients, and streamlined content.
`docs/Document-clean.kml`	New KML document defining geographic data for visualization.
`docs/alternatives.rst`	Added section listing alternative KML libraries with descriptions.
`docs/conf.py`	Added new Sphinx extensions and updated versioning logic.
`docs/create_kml_files.rst`	New documentation file providing guides on creating KML files for CO2 emissions data.
`docs/fastkml.rst`	Restructured documentation to enhance clarity and organization.
`docs/index.rst`	Updated to streamline content and reflect new sections.
`docs/installing.rst`	Deleted file with installation instructions.
`docs/modules.rst`	Removed section header for the `fastkml` module.
`docs/quickstart.rst`	New documentation file providing a quickstart guide for KML file creation.
`docs/reference_guide.rst`	Deleted structured reference guide for the `fastkml` library.
`docs/usage_guide.rst`	Deleted comprehensive usage guide for the `fastkml` library.
`docs/working_with_kml.rst`	New documentation file detailing how to work with KML files.
`examples/CreateKml.py`	Deleted example script for creating KML documents.
`examples/README.md`	Updated title and content for clarity regarding usage examples.
`examples/gx_cascading_style.kml`	New KML document defining styles and placemarks for geographic visualization.
`fastkml/__init__.py`	Updated imports and `__all__` declaration for clarity and organization.
`fastkml/about.py`	Updated version number from "1.0.a13" to "1.0.0b1".
`fastkml/atom.py`	Modified attribute types in `Link` and `_Person` classes for improved type safety.
`fastkml/base.py`	Simplified equality check in `_XMLObject` class and renamed method for parsing strings.
`fastkml/containers.py`	Updated style retrieval logic in `Document` class.
`fastkml/data.py`	Modified registration logic for `SimpleField`, `Data`, and `SchemaData` classes.
`fastkml/enums.py`	Renamed enum member and added new method in `AltitudeMode` class.
`fastkml/features.py`	Enhanced attribute handling in `Snippet`, `_Feature`, `Placemark`, and `NetworkLink` classes.
`fastkml/geometry.py`	Improved handling of geometries and updated class structures.
`fastkml/gx.py`	Enhanced handling of KML extensions related to the `gx` namespace.
`fastkml/helpers.py`	Added utility functions for KML data handling.
`fastkml/kml.py`	Updated methods for handling KML elements.
`fastkml/links.py`	Modified attribute types and updated registrations in `Link` class.
`fastkml/overlays.py`	Enhanced attribute handling in overlay classes.
`fastkml/registry.py`	Updated type annotations and improved flexibility in the registry's functionality.
`fastkml/schema/*.xsd`	Introduced new XML Schema Definition files for KML extensions and Atom elements.
`pyproject.toml`	Updated project metadata, consolidated dependencies, and refined configuration settings.
`tests/*.py`	Numerous updates to test cases reflecting changes in method signatures, improved error handling, and added tests.

Possibly related PRs

#338: Related to updates in KML parsing methods and testing framework enhancements.
#364: Updates to testing workflow and coverage thresholds align with the main PR's focus on testing practices.
#365: Enhancements in test coverage for KML functionalities relate to the main PR's emphasis on testing practices.
#367: Focus on improving coverage and testing geometries complements the main PR's changes.
#370: Removal of outdated tests and addition of new assertions align with the main PR's goal of improving the testing framework.

Suggested labels

enhancement, Tests

Suggested reviewers

cleder

🐰 In the meadow, changes bloom,
With tests and docs, we clear the gloom.
KML shines, with styles anew,
A rabbit's cheer for all we do!
Let's hop along, our code refined,
In every line, our joy aligned! 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 4 weeks ago

Preparing review...

ellipsis-dev[bot] commented 4 weeks ago

:warning: This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev

Generated with :heart: by ellipsis.dev

github-actions[bot] commented 4 weeks ago

Preparing review...

github-actions[bot] commented 4 weeks ago

Failed to generate code suggestions for PR

codiumai-pr-agent-free[bot] commented 4 weeks ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Code Complexity
The helper functions have been significantly refactored and expanded. Verify that the new implementations, especially get_value and the new datetime and coordinate handling functions, work correctly across all use cases. API Changes
The geometry classes have been modified, with some attributes moved or removed. Ensure these changes don't break existing functionality and are properly documented. Test Coverage
Many tests have been updated or added. Verify that these changes provide adequate coverage for the new and modified functionality in the geometry classes.

what-the-diff[bot] commented 4 weeks ago

PR Summary

Updated Python version and dependencies: The changes include updates in Python version, increase in pytest coverage, and inclusion of document packages in installation dependencies.
Improved GitHub Actions workflow: GitHub Actions workflow has been updated to run example scripts, reorganize steps, conditionally publish only on pushes to the 'main' branch, and test installation on Test PyPI.
Documentation and Sphinx configuration enhancements: New documentation files have been added and existing ones have been updated. Sphinx configuration has been enhanced with added extensions.
Quickstart guide and example updates: The 'quickstart.rst' file has been updated with a comprehensive guide and code examples. Some redundant example scripts were removed while new image files were added.
Code adjustments and improvements: New KML file and shapefile data have been added, some Python files have been renamed, method names have been modified, version in 'about.py' has been updated, and code organization has been improved.
Improved altitude mode documentation and defaults: The explanation for altitude modes has been revised for better clarity. Default values for optional attributes in a few classes have been introduced.
Inclusion of XML Schema Definition (XSD) files and Style modifications: New XSD files have been added to enhance XML validation capabilities. 'style.py' has been modified to change 'color' attribute type hint and default values for various attributes.
Updates in 'utils.py', 'validator.py', and 'views.py': New utility functions have been introduced, a new module for KML validation has been added, and default values for several properties in 'views.py' have been set.
Method renaming and improved tests: Method names have been refactored in multiple files to align with updated naming convention. New tests for container creation, feature appending and error handling have been added.
Enhancements in testing: The testing suite has been updated with new tests to assert GeometryError, check verbose and terse output, adjust string output precision, and handle KML parsing errors.
Polygon and Helper function tests: New tests have been added to cover features like 'extrude' and altitude mode configurations and to validate handling of attributes as float, enum and boolean values.
Testing updates with Hypothesis: A new suite for Hypothesis testing has been created including new test files and strategies to generate test cases, focus on serialization and deserialization behavior and asserting roundtrip behaviour for XML objects.
Testing updates and enhancements: The changes include replacing 'class_from_string' with 'from_string' for consistency, ensuring coordinate formats, handling None cases in style map and enhancing existing test cases.
Refactoring in multiple test files: The test files have been refactored for readability and consistency. Additional improvements in the error messages and new test files for utility functions and validating logic have also been added.

codiumai-pr-agent-free[bot] commented 4 weeks ago

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Enhancement	Use parametrized tests to cover multiple invalid input scenarios for Track.from_string method ___ Consider using parametrized tests for `test_track_from_str_invalid_when` and `test_track_from_str_invalid_coord` to test multiple invalid inputs. [tests/gx_test.py [367-393]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR367-R393) ```diff -def test_track_from_str_invalid_when(self) -> None: - doc = """ +@pytest.mark.parametrize("invalid_input, invalid_field", [ + ("2010-02-32T02:02:09Z", "when"), + ("XYZ 37.371915 156.000000", "coord"), +]) +def test_track_from_str_invalid_input(self, invalid_input: str, invalid_field: str) -> None: + doc = f""" - 2010-02-32T02:02:09Z + 2010-02-14T02:02:09Z 45.54676 66.2342 77.0 - -122.207881 37.371915 156.000000 + {invalid_input} """ track = Track.from_string(doc, strict=False) assert track.track_items == [] -def test_track_from_str_invalid_coord(self) -> None: - doc = """ - - 2010-02-14T02:02:09Z - 45.54676 66.2342 77.0 - XYZ 37.371915 156.000000 - - """ - - track = Track.from_string(doc, strict=False) - - assert track.track_items == [] - ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 8 Why: Parametrizing the tests for invalid inputs significantly improves test coverage and reduces code duplication, making the tests more maintainable and comprehensive.	8
	Add input validation for coordinate values to ensure data integrity ___ In the `coords_subelement_list_kwarg` function, consider adding input validation for the coordinate values to ensure they are valid before processing them further. [fastkml/helpers.py [1101-1110]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1101-R1110) ```diff def coords_subelement_list_kwarg( , element: Element, ns: str, name_spaces: Dict[str, str], node_name: str, kwarg: str, classes: Tuple[Type[object], ...], strict: bool, ) -> Dict[str, List[PointType]]: + def validate_coordinate(coord: str) -> bool: + try: + float(coord) + return True + except ValueError: + return False + # Rest of the function implementation + # Use validate_coordinate() to check each coordinate value + ``` - [ ] Apply this suggestion* Suggestion importance[1-10]: 7 Why: Adding input validation for coordinate values is a valuable suggestion that can improve data integrity and prevent potential errors downstream. It addresses a potential vulnerability in the code and enhances its robustness.	7
	Add a test case to verify that Track initialization raises an exception when whens and coords have different lengths ___ Consider adding a test case for the `Track` class that verifies the behavior when both `whens` and `coords` are provided but have different lengths. [tests/gx_test.py [179-197]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR179-R197) ```diff def test_track_from_whens_and_coords(self) -> None: whens = [ KmlDateTime( datetime.datetime(2023, 1, 1, 0, 0, 0, tzinfo=datetime.timezone.utc), ), ] coords = [(1, 2)] track = Track( whens=whens, coords=coords, ) assert "when>" in track.to_string() assert ">2023-01-01T00:00:00+00:00" in track.to_string() assert ">1 2 Suggestion importance[1-10]: 7 Why: This suggestion adds an important edge case test, ensuring that the Track class correctly handles mismatched lengths of whens and coords, which enhances the robustness of the test suite.	7
	Add a test case to verify Track behavior with TrackItems containing None values for when, coord, or angle ___ Consider adding a test case for the `Track` class that verifies the behavior when `track_items` contain `None` values for `when`, `coord`, or `angle`. [tests/gx_test.py [160-175]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR160-R175) ```diff def test_track_from_track_items(self) -> None: time1 = KmlDateTime( datetime.datetime(2023, 1, 1, 0, 0, 0, tzinfo=datetime.timezone.utc), ) angle = Angle() - track_items = [TrackItem(when=time1, coord=geo.Point(1, 2), angle=angle)] + track_items = [ + TrackItem(when=time1, coord=geo.Point(1, 2), angle=angle), + TrackItem(when=None, coord=geo.Point(3, 4), angle=None), + TrackItem(when=time1, coord=None, angle=angle), + ] track = Track( track_items=track_items, ) assert "when>" in track.to_string() assert ">2023-01-01T00:00:00+00:00" in track.to_string() assert ">1 23 4" in track.to_string() assert ">0.0 0.0 0.0 Suggestion importance[1-10]: 7 Why: This suggestion improves test coverage by verifying the Track class's behavior with TrackItems containing None values, which is an important edge case that should be tested.	7
	Simplify attribute retrieval and default value handling in the get_value function ___ In the `get_value` function, consider using the `getattr` function with a default value instead of using `getattr` and then checking for `None`. This can simplify the code and reduce the number of comparisons. [fastkml/helpers.py [121-124]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR121-R124) ```diff -value = getattr(obj, attr_name, None) -if value is None and default is not None and verbosity == Verbosity.verbose: - return default +value = getattr(obj, attr_name, default) +if verbosity == Verbosity.verbose: + return value return None if value == default and verbosity == Verbosity.terse else value ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion offers a meaningful improvement in code readability and efficiency by simplifying the attribute retrieval and default value handling logic. It reduces the number of comparisons and makes the code more straightforward.	6
	Add a more precise type hint for the kml_geometries attribute ___ In the `MultiGeometry` class, consider adding a type hint for the `kml_geometries` attribute to improve code readability and catch potential type-related issues earlier. [fastkml/geometry.py [1243]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR1243-R1243) ```diff class MultiGeometry(_BaseObject): """A container for zero or more geometry primitives.""" - kml_geometries: List[Union[Point, LineString, Polygon, LinearRing, Self]] + kml_geometries: List[Union[Point, LineString, Polygon, LinearRing, 'MultiGeometry']] ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion improves code readability and can help catch potential type-related issues earlier. It's a valuable enhancement for maintainability and type safety.	6
	Improve exception testing by using a context manager and asserting the specific error message ___ Consider using a context manager with pytest.raises to ensure the exception is raised and to provide a more specific error message. [tests/gx_test.py [211-219]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR211-R219) ```diff -with pytest.raises( - ValueError, - match="^Cannot specify both geometry and track_items$", -): +with pytest.raises(ValueError) as excinfo: Track( whens=whens, coords=coords, track_items=track_items, ) +assert str(excinfo.value) == "Cannot specify both geometry and track_items" ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion enhances the exception testing by using a context manager and asserting the specific error message, which improves the test's precision and readability.	6
	Use a more specific exception type for invalid coordinates ___ Consider using a more specific exception type instead of `KMLWriteError` in the `coordinates_subelement` function. For example, you could create a custom exception like `InvalidCoordinatesError` to provide more precise error handling. [fastkml/geometry.py [166-168]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR166-R168) ```diff if not coords or len(coords[0]) not in (2, 3): msg = f"Invalid dimensions in coordinates '{coords}'" - raise KMLWriteError(msg) + raise InvalidCoordinatesError(msg) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 5 Why: Using a more specific exception type can improve error handling and debugging, but it's a minor improvement that doesn't address a critical issue.	5
	Use a list comprehension to simplify and potentially optimize the code ___ Consider using a list comprehension instead of a for loop in the `datetime_subelement_list_kwarg` function to make the code more concise and potentially more efficient. [fastkml/helpers.py [1082-1098]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1082-R1098) ```diff -args_list: List[KmlDateTime] = [] cls = classes[0] if subelements := element.findall(f"{ns}{node_name}"): - for subelement in subelements: - try: - args_list.append( - cls.parse(subelement.text), # type: ignore[attr-defined] - ) - except ValueError as exc: # noqa: PERF203 - handle_error( - error=exc, - strict=strict, - element=element, - node=subelement, - expected="DateTime", - ) + args_list = [ + cls.parse(subelement.text) # type: ignore[attr-defined] + for subelement in subelements + if not handle_error( + error=ValueError(), + strict=strict, + element=element, + node=subelement, + expected="DateTime", + ) + ] ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 4 Why: The suggestion to use a list comprehension could make the code more concise, but it might not significantly improve performance. It also changes the error handling logic, which could have unintended consequences.	4
	Use a dictionary comprehension for mapping geometry types ___ In the `create_kml_geometry` function, consider using a dictionary comprehension instead of a manually created dictionary for `_map_to_kml`. This can make the code more concise and easier to maintain. [fastkml/geometry.py [1420-1432]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR1420-R1432) ```diff _map_to_kml: Dict[ Union[Type[GeoType], Type[GeoCollectionType]], Type[KMLGeometryType], ] = { - geo.Point: Point, - geo.Polygon: Polygon, - geo.LinearRing: LinearRing, - geo.LineString: LineString, - geo.MultiPoint: MultiGeometry, - geo.MultiLineString: MultiGeometry, - geo.MultiPolygon: MultiGeometry, - geo.GeometryCollection: MultiGeometry, + geo_type: kml_type + for geo_type, kml_type in [ + (geo.Point, Point), + (geo.Polygon, Polygon), + (geo.LinearRing, LinearRing), + (geo.LineString, LineString), + (geo.MultiPoint, MultiGeometry), + (geo.MultiLineString, MultiGeometry), + (geo.MultiPolygon, MultiGeometry), + (geo.GeometryCollection, MultiGeometry), + ] } ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 4 Why: While this suggestion improves code conciseness and maintainability, it doesn't address any functional issues. The current implementation is already clear and working correctly.	4
	Use more specific exception types for better error handling and diagnostics ___ Use a more specific exception type instead of the general `ValueError` in the `datetime_subelement_kwarg` and `datetime_subelement_list_kwarg` functions. This will make error handling more precise and informative. [fastkml/helpers.py [1058-1067]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1058-R1067) ```diff -except ValueError as exc: +except (ValueError, TypeError) as exc: handle_error( error=exc, strict=strict, element=element, node=node, expected="DateTime", ) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 3 Why: While the suggestion to use more specific exception types is valid, it offers only a minor improvement in error handling. The existing code already handles ValueError, which is sufficient for most datetime parsing errors.	3
Performance	Improve memory efficiency in equality comparison ___ In the `__eq__` method of the `Point` class, consider using `all()` with a generator expression instead of a list comprehension for better memory efficiency, especially when dealing with large objects. [fastkml/geometry.py [479-492]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR479-R492) ```diff def __eq__(self, other: object) -> bool: """Check if the Point objects are equal.""" if isinstance(other, Point): return all( getattr(self, attr) == getattr(other, attr) - for attr in ( - "extrude", - "altitude_mode", - "geometry", - xml_attrs, - self._get_splat(), - ) + for attr in ("extrude", "altitude_mode", "geometry", xml_attrs, self._get_splat()) ) return super().__eq__(other) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 3 Why: The suggestion offers a minor performance optimization, but the impact is likely negligible for most use cases. The current implementation is already quite efficient.	3

💡 Need additional feedback ? start a PR chat

codiumai-pr-agent-free[bot] commented 4 weeks ago

CI Failure Feedback 🧐

**Action:** Run pr agent on every pull request, respond to user comments

**Failed stage:** [PR Agent action step](https://github.com/cleder/fastkml/actions/runs/11671938870/job/32499449150) [❌]

**Failed test name:** ""

**Failure summary:** The action failed due to a ValueError in the Python shlex module. The error occurred because there
was a missing closing quotation mark in the input being processed by the shlex module.

Relevant error logs:

```yaml 1: ##[group]Operating System 2: Ubuntu ... 154: ^^^^^^^^^^^ 155: File "/usr/local/lib/python3.12/shlex.py", line 300, in __next__ 156: token = self.get_token() 157: ^^^^^^^^^^^^^^^^ 158: File "/usr/local/lib/python3.12/shlex.py", line 109, in get_token 159: raw = self.read_token() 160: ^^^^^^^^^^^^^^^^^ 161: File "/usr/local/lib/python3.12/shlex.py", line 191, in read_token 162: raise ValueError("No closing quotation") 163: ValueError: No closing quotation ```

✨ CI feedback usage guide:

The CI feedback tool (`/checks)` automatically triggers when a PR has a failed check. The tool analyzes the failed checks and provides several feedbacks: - Failed stage - Failed test name - Failure summary - Relevant error logs In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: ``` /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}" ``` where `{repo_name}` is the name of the repository, `{run_number}` is the run number of the failed check, and `{job_number}` is the job number of the failed check. #### Configuration options - `enable_auto_checks_feedback` - if set to true, the tool will automatically provide feedback when a check is failed. Default is true. - `excluded_checks_list` - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list. - `enable_help_text` - if set to true, the tool will provide a help message with the feedback. Default is true. - `persistent_comment` - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true. - `final_update_message` - if `persistent_comment` is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true. See more information about the `checks` tool in the [docs](https://pr-agent-docs.codium.ai/tools/ci_feedback/).

Category	Suggestion	Score
Enhancement	Use parametrized tests to cover multiple invalid input scenarios for Track.from_string method ___ Consider using parametrized tests for `test_track_from_str_invalid_when` and `test_track_from_str_invalid_coord` to test multiple invalid inputs. [tests/gx_test.py [367-393]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR367-R393) ```diff -def test_track_from_str_invalid_when(self) -> None: - doc = """ +@pytest.mark.parametrize("invalid_input, invalid_field", [ + ("2010-02-32T02:02:09Z", "when"), + ("XYZ 37.371915 156.000000", "coord"), +]) +def test_track_from_str_invalid_input(self, invalid_input: str, invalid_field: str) -> None: + doc = f""" - 2010-02-32T02:02:09Z + 2010-02-14T02:02:09Z 45.54676 66.2342 77.0 - -122.207881 37.371915 156.000000 + {invalid_input} """ track = Track.from_string(doc, strict=False) assert track.track_items == [] -def test_track_from_str_invalid_coord(self) -> None: - doc = """ - - 2010-02-14T02:02:09Z - 45.54676 66.2342 77.0 - XYZ 37.371915 156.000000 - - """ - - track = Track.from_string(doc, strict=False) - - assert track.track_items == [] - ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 8 Why: Parametrizing the tests for invalid inputs significantly improves test coverage and reduces code duplication, making the tests more maintainable and comprehensive.	8
	Add input validation for coordinate values to ensure data integrity ___ In the `coords_subelement_list_kwarg` function, consider adding input validation for the coordinate values to ensure they are valid before processing them further. [fastkml/helpers.py [1101-1110]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1101-R1110) ```diff def coords_subelement_list_kwarg( , element: Element, ns: str, name_spaces: Dict[str, str], node_name: str, kwarg: str, classes: Tuple[Type[object], ...], strict: bool, ) -> Dict[str, List[PointType]]: + def validate_coordinate(coord: str) -> bool: + try: + float(coord) + return True + except ValueError: + return False + # Rest of the function implementation + # Use validate_coordinate() to check each coordinate value + ``` - [ ] Apply this suggestion* Suggestion importance[1-10]: 7 Why: Adding input validation for coordinate values is a valuable suggestion that can improve data integrity and prevent potential errors downstream. It addresses a potential vulnerability in the code and enhances its robustness.	7
	Add a test case to verify that Track initialization raises an exception when whens and coords have different lengths ___ Consider adding a test case for the `Track` class that verifies the behavior when both `whens` and `coords` are provided but have different lengths. [tests/gx_test.py [179-197]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR179-R197) ```diff def test_track_from_whens_and_coords(self) -> None: whens = [ KmlDateTime( datetime.datetime(2023, 1, 1, 0, 0, 0, tzinfo=datetime.timezone.utc), ), ] coords = [(1, 2)] track = Track( whens=whens, coords=coords, ) assert "when>" in track.to_string() assert ">2023-01-01T00:00:00+00:00" in track.to_string() assert ">1 2 Suggestion importance[1-10]: 7 Why: This suggestion adds an important edge case test, ensuring that the Track class correctly handles mismatched lengths of whens and coords, which enhances the robustness of the test suite.	7
	Add a test case to verify Track behavior with TrackItems containing None values for when, coord, or angle ___ Consider adding a test case for the `Track` class that verifies the behavior when `track_items` contain `None` values for `when`, `coord`, or `angle`. [tests/gx_test.py [160-175]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR160-R175) ```diff def test_track_from_track_items(self) -> None: time1 = KmlDateTime( datetime.datetime(2023, 1, 1, 0, 0, 0, tzinfo=datetime.timezone.utc), ) angle = Angle() - track_items = [TrackItem(when=time1, coord=geo.Point(1, 2), angle=angle)] + track_items = [ + TrackItem(when=time1, coord=geo.Point(1, 2), angle=angle), + TrackItem(when=None, coord=geo.Point(3, 4), angle=None), + TrackItem(when=time1, coord=None, angle=angle), + ] track = Track( track_items=track_items, ) assert "when>" in track.to_string() assert ">2023-01-01T00:00:00+00:00" in track.to_string() assert ">1 23 4" in track.to_string() assert ">0.0 0.0 0.0 Suggestion importance[1-10]: 7 Why: This suggestion improves test coverage by verifying the Track class's behavior with TrackItems containing None values, which is an important edge case that should be tested.	7
	Simplify attribute retrieval and default value handling in the get_value function ___ In the `get_value` function, consider using the `getattr` function with a default value instead of using `getattr` and then checking for `None`. This can simplify the code and reduce the number of comparisons. [fastkml/helpers.py [121-124]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR121-R124) ```diff -value = getattr(obj, attr_name, None) -if value is None and default is not None and verbosity == Verbosity.verbose: - return default +value = getattr(obj, attr_name, default) +if verbosity == Verbosity.verbose: + return value return None if value == default and verbosity == Verbosity.terse else value ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion offers a meaningful improvement in code readability and efficiency by simplifying the attribute retrieval and default value handling logic. It reduces the number of comparisons and makes the code more straightforward.	6
	Add a more precise type hint for the kml_geometries attribute ___ In the `MultiGeometry` class, consider adding a type hint for the `kml_geometries` attribute to improve code readability and catch potential type-related issues earlier. [fastkml/geometry.py [1243]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR1243-R1243) ```diff class MultiGeometry(_BaseObject): """A container for zero or more geometry primitives.""" - kml_geometries: List[Union[Point, LineString, Polygon, LinearRing, Self]] + kml_geometries: List[Union[Point, LineString, Polygon, LinearRing, 'MultiGeometry']] ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion improves code readability and can help catch potential type-related issues earlier. It's a valuable enhancement for maintainability and type safety.	6
	Improve exception testing by using a context manager and asserting the specific error message ___ Consider using a context manager with pytest.raises to ensure the exception is raised and to provide a more specific error message. [tests/gx_test.py [211-219]](https://github.com/cleder/fastkml/pull/377/files#diff-4ac18980a60351fdb90de277ced50c1429130b451c36d8cb7ef5fa9e9b90203dR211-R219) ```diff -with pytest.raises( - ValueError, - match="^Cannot specify both geometry and track_items$", -): +with pytest.raises(ValueError) as excinfo: Track( whens=whens, coords=coords, track_items=track_items, ) +assert str(excinfo.value) == "Cannot specify both geometry and track_items" ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion enhances the exception testing by using a context manager and asserting the specific error message, which improves the test's precision and readability.	6
	Use a more specific exception type for invalid coordinates ___ Consider using a more specific exception type instead of `KMLWriteError` in the `coordinates_subelement` function. For example, you could create a custom exception like `InvalidCoordinatesError` to provide more precise error handling. [fastkml/geometry.py [166-168]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR166-R168) ```diff if not coords or len(coords[0]) not in (2, 3): msg = f"Invalid dimensions in coordinates '{coords}'" - raise KMLWriteError(msg) + raise InvalidCoordinatesError(msg) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 5 Why: Using a more specific exception type can improve error handling and debugging, but it's a minor improvement that doesn't address a critical issue.	5
	Use a list comprehension to simplify and potentially optimize the code ___ Consider using a list comprehension instead of a for loop in the `datetime_subelement_list_kwarg` function to make the code more concise and potentially more efficient. [fastkml/helpers.py [1082-1098]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1082-R1098) ```diff -args_list: List[KmlDateTime] = [] cls = classes[0] if subelements := element.findall(f"{ns}{node_name}"): - for subelement in subelements: - try: - args_list.append( - cls.parse(subelement.text), # type: ignore[attr-defined] - ) - except ValueError as exc: # noqa: PERF203 - handle_error( - error=exc, - strict=strict, - element=element, - node=subelement, - expected="DateTime", - ) + args_list = [ + cls.parse(subelement.text) # type: ignore[attr-defined] + for subelement in subelements + if not handle_error( + error=ValueError(), + strict=strict, + element=element, + node=subelement, + expected="DateTime", + ) + ] ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 4 Why: The suggestion to use a list comprehension could make the code more concise, but it might not significantly improve performance. It also changes the error handling logic, which could have unintended consequences.	4
	Use a dictionary comprehension for mapping geometry types ___ In the `create_kml_geometry` function, consider using a dictionary comprehension instead of a manually created dictionary for `_map_to_kml`. This can make the code more concise and easier to maintain. [fastkml/geometry.py [1420-1432]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR1420-R1432) ```diff _map_to_kml: Dict[ Union[Type[GeoType], Type[GeoCollectionType]], Type[KMLGeometryType], ] = { - geo.Point: Point, - geo.Polygon: Polygon, - geo.LinearRing: LinearRing, - geo.LineString: LineString, - geo.MultiPoint: MultiGeometry, - geo.MultiLineString: MultiGeometry, - geo.MultiPolygon: MultiGeometry, - geo.GeometryCollection: MultiGeometry, + geo_type: kml_type + for geo_type, kml_type in [ + (geo.Point, Point), + (geo.Polygon, Polygon), + (geo.LinearRing, LinearRing), + (geo.LineString, LineString), + (geo.MultiPoint, MultiGeometry), + (geo.MultiLineString, MultiGeometry), + (geo.MultiPolygon, MultiGeometry), + (geo.GeometryCollection, MultiGeometry), + ] } ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 4 Why: While this suggestion improves code conciseness and maintainability, it doesn't address any functional issues. The current implementation is already clear and working correctly.	4
	Use more specific exception types for better error handling and diagnostics ___ Use a more specific exception type instead of the general `ValueError` in the `datetime_subelement_kwarg` and `datetime_subelement_list_kwarg` functions. This will make error handling more precise and informative. [fastkml/helpers.py [1058-1067]](https://github.com/cleder/fastkml/pull/377/files#diff-b5b3941187e8c15a6401d21669f3dd0d541c710ecbb6238620a56e24305fc02cR1058-R1067) ```diff -except ValueError as exc: +except (ValueError, TypeError) as exc: handle_error( error=exc, strict=strict, element=element, node=node, expected="DateTime", ) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 3 Why: While the suggestion to use more specific exception types is valid, it offers only a minor improvement in error handling. The existing code already handles ValueError, which is sufficient for most datetime parsing errors.	3
Performance	Improve memory efficiency in equality comparison ___ In the `__eq__` method of the `Point` class, consider using `all()` with a generator expression instead of a list comprehension for better memory efficiency, especially when dealing with large objects. [fastkml/geometry.py [479-492]](https://github.com/cleder/fastkml/pull/377/files#diff-47314ad0817fc0fdde5a4ccab1250d104c27d592f1dd0f9952b454a4e3cdf65dR479-R492) ```diff def __eq__(self, other: object) -> bool: """Check if the Point objects are equal.""" if isinstance(other, Point): return all( getattr(self, attr) == getattr(other, attr) - for attr in ( - "extrude", - "altitude_mode", - "geometry", - xml_attrs, - self._get_splat(), - ) + for attr in ("extrude", "altitude_mode", "geometry", xml_attrs, self._get_splat()) ) return super().__eq__(other) ``` - [ ] Apply this suggestion Suggestion importance[1-10]: 3 Why: The suggestion offers a minor performance optimization, but the impact is likely negligible for most use cases. The current implementation is already quite efficient.	3

cleder / fastkml

1.0.0 beta 1 #377

User description

PR Type

Description

Changes walkthrough 📝

Summary by CodeRabbit

Reviewer's Guide by Sourcery

Updated class diagram for the Geometry classes

Updated class diagram for the Boundary classes

Updated class diagram for the Track and MultiTrack classes

Updated class diagram for the Time classes

File-Level Changes

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

PR Reviewer Guide 🔍

PR Summary

PR Code Suggestions ✨

CI Failure Feedback 🧐