Geometries should be immutable and hashable #128 (Sourcery refactored)

[sourcery-ai[bot]]

Pull Request #177 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the 128-geometries-should-be-immutable-and-hashable branch, then run:

git fetch origin sourcery/128-geometries-should-be-immutable-and-hashable
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[watermelon-copilot-for-code-review[bot]]

Please login to Watermelon to see the results

[what-the-diff[bot]]

PR Summary

• Update in Initial Checks and Setup of Geometry In the geometry setup file, this PR makes improvements to how it checks and deals with 'holes' in the system. Earlier, there was an ambiguity in understanding how these were being checked. This update ensures that the program only proceeds if there are 'holes' detected.

• Removal of Unused Variables and Enhancements As a measure for code clean up, the PR removes an unused variable that was defined previously. It introduces a more streamlined process to deal with 'holes'. The enhancements make the process of dealing with the system's 'holes' more efficient.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e5e9e04) 100.00% compared to head (731a29e) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 128-geometries-should-be-immutable-and-hashable #178 +/- ## ================================================================================= Coverage 100.00% 100.00% ================================================================================= Files 21 21 Lines 2314 2312 -2 ================================================================================= - Hits 2314 2312 -2 ``` | [Files](https://app.codecov.io/gh/cleder/pygeoif/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann) | Coverage Δ | | |---|---|---| | [pygeoif/geometry.py](https://app.codecov.io/gh/cleder/pygeoif/pull/178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Ledermann#diff-cHlnZW9pZi9nZW9tZXRyeS5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ghost]

👇 Click on the image for a new way to code review

#### [](https://app.codesee.io/r/reviews?pr=178&src=https%3A%2F%2Fgithub.com%2Fcleder%2Fpygeoif) #### Legend

[watermelon-copilot-for-code-review[bot]]

Please login to Watermelon to see the results

[watermelon-copilot-for-code-review[bot]]

Please login to Watermelon to see the results