Open Charlie-robin opened 7 months ago
Hi Charlie, Thank you very much for your feedback and suggestions on my game project. I really like the idea of extending this with different themes. Thanks for your suggested code on how to organise the card/theme data to dynamically create the HTML. It is really helpful to see and I’m excited to have a go at implementing it. I’d love to have an Animal Crossing theme and can visualise the cards and audio already 😄
Thanks also for the info on the shuffleCards function and the helpful link on typescript generics 👍
Feedback
Requirements
Score
MARKING-SCHEME
Notes
The Code
Positive
You have a hosted and functioning dynamic typescript game, good going!
Your game logic is well-structured and separated into separate files with clear and related responsibilities
utilities.ts
and Functions likecheckIfSelectedCardsMatch
,resetGame
,startTimer
, etc make the code easier to understand.I love all of the little features you have added as well, you have enjoyed yourself.
Your
setInterval()
is interesting, I like that you have researched this and been able to implement this functionality as timers can be tricky.Good README.md as well!
Constructive
shuffleCards
function is good, it is currently tied to gettingHTMLDivElement[]
and also returning that type. If you introduced generics you could make your function shuffle any array.