search

cleemesser / python-edf

source for python-edf project provides package of edflib to read European Data Format EEGs
2 stars 3 forks source link

bug/issue5 fix bug with "pip install edflib". Limit to numpy<2 #6

Closed simondub closed 1 month ago

simondub commented 2 months ago

Compilation error with numpy>2. Limit to numpy<2. More work is needed for numpy>2.

Summary by Sourcery

This pull request addresses a compilation error by restricting the numpy version to be less than 2 in the setup.py file.

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request addresses a compilation error when using numpy versions greater than 2. The setup.py file was modified to limit the numpy version to less than 2 by updating the setup_requires line. Additionally, a comment line was added to the include_dirs section.

File-Level Changes

Files Changes
setup.py Updated the setup configuration to limit numpy version to <2 to avoid compilation errors.
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.