search

clef / clef-wordpress

The official Clef plugin for WordPress.
http://wordpress.org/plugins/wpclef
44 stars 24 forks source link

Update state cookie name for Pantheon compatibility #238

Closed jessepollak closed 8 years ago

jessepollak commented 8 years ago

This commit changes the name of the cookie used to store the OAuth state parameter from _clef_state to SESSclefstate. We do this to avoid deletion by certain caches (like Varnish on Pantheon).

PLUG-9 #finish

landakram commented 8 years ago

LGTM

landakram commented 8 years ago

Is this going to break existing sessions in any meaningful way?

jessepollak commented 8 years ago

@landakram it shouldn't — these sessions only last 24 hours, so it's basically like triggering that expiration early. the only situation in which it would affect a user is if they had two browser windows open and they updated Clef in one, then tried to log in in the other. in that case, they would see the state error and then the next time they tried to log in, everything would work.