Closed jessepollak closed 8 years ago
@lolux I pushed the migration from previous versions, bumped the version to 2.6.0
and pushed v2.6.0-beta1
here.
@jessepollak most excellent, thank you.
The third-party beta testing and my own testing is nearly complete. We have a green light from Pantheon already. I'll ping back here once the remaining tests have finished.
woot - keep me updated!
On Wed, Jun 29, 2016 at 2:03 PM, lolux notifications@github.com wrote:
@jessepollak https://github.com/jessepollak most excellent, thank you.
The third-party beta testing and my own testing is nearly complete. We have a green light from Pantheon already. I'll ping back here once the remaining tests have finished.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clef/clef-wordpress/pull/255#issuecomment-229488167, or mute the thread https://github.com/notifications/unsubscribe/ABDA4V0RU3HXp6SPG85F3Oato1cZt4iwks5qQt20gaJpZM4I_fBv .
Jesse Pollak CPO at Clef @jessepollak https://twitter.com/jessepollak
Thanks for all your hard work on this @lolux!
@lolux I checked out the GoDaddy test site and figured out what was going on. Basically, with
wp_login_url()
function was returning a full URL, while the$GLOBALS['pagenow']
variable was just the path. I added a more thorough check that:1) Checks whether the setting is set, and if so returns true 2) Follows this answer to check whether we are on the login page. If we are, returns true 3) Looks at the path of the current page and sees if it's the same as the path from
wp_login_url()
orwp_registration_url()
Let me know what you think!