search

cleidigh / EditEmailSubject-MX

Conversion exercise for Thunderbird MailExtensions
GNU General Public License v3.0
16 stars 9 forks source link

Don't "pre-remove" the JAR compression #1

Closed eyalroz closed 4 years ago

eyalroz commented 4 years ago

A lot of extensions use JAR, for various reasons. Perhaps they're all invalid, perhaps not.

If JARs are completely unsupported in MailExtensions - fine, lets remove them, but the removal is part of the process which should be elucidated in this repository. So I suggest the initial commit(s) and release be overwritten to have the JAR still.

cleidigh commented 4 years ago

@eyalroz I did two things I have the original as is in src-original I also maintained the original with the jar as the first commit I only removed it after that because it makes everything easier.
I was going to documented with a mettaissue

Also I made tags for these so they are easy to get

eyalroz commented 4 years ago

That's good. But... removing the JAR should be a regular issue ("task"-labeled?) which should be filed, then the action taken - so that we can keep track and so that commits relate to issues (hopefully every commit relates to an issue).

cleidigh commented 4 years ago

@eyalroz Do you know where the documentation is for thick covers using jar approach? we could reference that and perhaps also find the answer to your question if MX extensions will ever use that paradigm. I don't know the answer but I would guess not only because of the double compression , but to be honest since I've never used it perhaps I'm missing something.

neandr commented 4 years ago

The original XPI has a JAR and the install.rdf has true</em:unpack> So everything is OK with it. Please refer also to unpackingXPI which says it's not necessary to pack a JAR nowadays. For our project it's not an issue, so going to close it.