cleidigh / Localfolder-TB

Thunderbird Add-On to add additional local folders to accounts
Mozilla Public License 2.0
14 stars 6 forks source link

LocalFolders upgrade requires unexpected permissions #41

Closed rthouvenin closed 3 years ago

rthouvenin commented 3 years ago

I currently have version 2.0.2 installed on Thunderbird 68.10, and Thunderbird suggests that I could upgrade the add-on but I need to grant the following permissions:

What does it mean? Why would this add-on require these permissions and why not before? I found the permissions documentation, and it makes me think the descriptions I pasted above are poorly worded, but it still not clear what it means. I know nothing about Thunderbird development, sorry if this is a basic question :)

Thanks for your work!

cleidigh commented 3 years ago

@rthouvenin thanks for the question, you are correct the permissions are not exactly crystal clear. basically everything is related to an increased ,granular security model. the code for localfolders requires the use of "privileged APIs", specifically filesystem manipulation as well as a content tab. the file system should be obvious it has always been Required, the tab permission is necessary for the account settings additions

if you add other extensions especially under 78+ you will see other examples of this. unfortunately the permission text is not under the extensions Control.

Christopher

rthouvenin commented 3 years ago

Thanks for the clarification! I will address the wording issue with Thunderbird or whichever Mozilla lib this falls under (I suspect this is because it is shared with Firefox)