search

cleidigh / ThunderKdB

Thunderbird Addon Code Knowledge Base
11 stars 7 forks source link

display more adjacent lines #5

Open opto opened 5 years ago

opto commented 5 years ago

example: trying to see how others use richlistbox.

I fiind the occurance of richlistbox with xpiLib, but would need to click into all extensions to see how it is used. This becaue it shows the occurrance of the search item, but not the next lines (or not enough of them)

If more neighborng lines were shown, I could judge which extensions to click into, because I could see the code 'inside' the richlistbox, as example.

cleidigh commented 5 years ago

@opto My first xpiLib issues/suggestions - awesome thanks! Obviously great developers think alike ;-) Both of your suggestions are EXACTLY the same two thoughts I had when I was first working on this. Currently the way that I do this is to utilize GH for all the hard work (actual code search/HTML presentation) in other words GH search limitations apply. So far I have not been able to find an option for either of these.

One question: until recently I'd not realize you could click on the code line. I thought you could only click on the filename which takes you to the top of the file not the code snippet. That gets you pretty quickly to see everything you need except you may want to open it in another tab. You may already be doing but I just wanted to let you know since I think it's pretty quick.

If this tool is determined to be really useful, I can continue to enhance it. It is possible to use the search API directly which adds more flexibility. I purposely stayed away from that because it would be a massive amount of work specially for the presentation. I will have to investigate if that would help and what it would really take.

In the meantime what would be greatest the following:

I realized I need to do some help/description of use, but I'm not there yet and I want to see if it was help to you already. There is a bunch more that I have set up but have not discussed.

I think looks like you can get some ideas from TBsync and its code is already here. Christopher

opto commented 5 years ago

I find it extremely useful. Previously, I downloaded and unzipped interesting addons to learn from their code. This seems to do the same and can search over several addons.

yes, I can open files in another tab. But in Germnany, that can be fast or not, depending on my location. So a larger context would be nice - if time needed for that is appropriate. I hate all this clicking and waiting for webpages.

cleidigh commented 5 years ago

@opto that's exactly what I was too late when I started Thunderbird in February, downloading lots of extensions unzipping and inspecting code. Great, you are confirming the utility. I will continue to investigate how I can improve the output. I just want to make sure I address any other obvious missing items. I have to add the version information in the summaries for instance. Have you looked at the extension compatibility reports? Can you think of any other search filters that would be helpful? thanks again the feedbacks is really useful