search

cleidigh / printing-tools-ng

PrintingTools NG Thunderbird Extension - Printing Utilities
Other
36 stars 17 forks source link

Header "To" always in last position with locale "fr" #190

Closed DenB10 closed 1 year ago

DenB10 commented 1 year ago

Hello,

I am a French user so it's normal that I use the French version of Thunderbird ;)

I discovered a bug in PTNG that occurs if Thunderbird is in French but not in English (US)!

My configuration:

To reproduce the issue:

The error console doesn't seem to indicate anything wrong! Strange, isn't it? Note finally that I did the test on a new fresh Thunderbirdprofile with only PTNG installed as extension and the conclusion remains the same. So another extension isn't incriminated.

If you could debug or find an explanation for this phenomenon, I would be grateful.

P.S. : Are you interested in an improved translation in French, or not ?

cleidigh commented 1 year ago

@DenB10 Merci ! Your description and steps were very complete and precise. I reproduced it already. It was another case of an odd termination in Thunderbird's mime headers fr locale file "outwitting" my logic. I should have a beta fix out tomorrow, my fix looks good so far.

I would much appreciate any translation help ! I would love to increase our French user count, it's only around 700. If you are going to do a pull request do it against the v2.2.2 branch as I don't do dev on master.

Cheers @cleidigh

cleidigh commented 1 year ago

@DenB10 You can grab b2 beta from the top of the release status issue for v2.2.2

I did a bunch of hdr moves and looks good. @cleidigh

DenB10 commented 1 year ago

Works well, thank you for your responsiveness.

I'm now working on the French translation, it will be ready probably tomorrow. Just a remark though: would it be possible to add the possibility to localize the accesskeys in the context menu of the button? "Aide (H)", it's not very nice!

Thanks again and good night (it's late here)!

cleidigh commented 1 year ago

@DenB10 I think so, just have to play @cleidigh

DenB10 commented 1 year ago

I "Pull request" enhancements for the French localization, hope you will like it.

cleidigh commented 1 year ago

@DenB10 Thanks for the PRs. Unfortunately I can't merge the dtd or properties files as they do not match up. Each file has one key value pair and any modification should always result in the same number of lines.

The help file is a different issue. The lines in that might vary slightly. The formatting and styleing should not be changed, one because we want consistency between the locales and for future changes. The classes should never be altered. You removed notranslate and code1 as examples.

The way I do help is to use the en as master then I have special scripts for the Google api. Any changes from this have to be manualy managed so we want only the text changes making future diffs as easy to deal with as possible.

Hope this makes sense. Ask me anything you need to do them, especially the help. Salud @cleidigh

DenB10 commented 1 year ago

Hello @cleidigh ,

This is the first time I've encountered a blockage of this kind. It is true that I have deleted lines or elements that seemed unnecessary. In fact, it works very well for me.

Nevertheless, I understand your way of operating, and I'll review my copy and send you other pull requests that I hope can be merged !

Greetings

@DenB10

cleidigh commented 1 year ago

@DenB10 Afternoon... I did manually merge the dtd to restore ordering and removed entries. Just a suggestion (IMHO): When doing PRs on files like these even though ordering may not have a functional difference, maintaining it keeps comparison better. Also removing things if you don't know their purpose creates potential issues. No big deal for now. The important thing is the fr ui looks Tres bien now (even my high school French can tell that %-) thanks)

I have to play with the help today among other support issues. Have to merge some other stuff into it also. @cleidigh

DenB10 commented 1 year ago

I did manually merge the dtd to restore ordering and removed entries.

I am sorry to have caused you this extra work instead of helping you!

The important thing is the fr ui looks Tres bien now (even my high school French can tell that %-) thanks)

It is I who thank you for your efforts in keeping this great extension alive.

P.S.: I just pulled request a new version of the help file that will allow a better comparison. Have I learned my lesson well?

cleidigh commented 1 year ago

@DenB10 Phew...b3 has a bunch of stuff, just posted. The fr ui and help look great. I did have to make one change to help... Adding you to the credits 🥇 %-)

Have to add to the other locales when I tweak them with the other diffs. Very much appreciated.

See release status 👍 - #189 @cleidigh

DenB10 commented 1 year ago

Adding you to the credits %-)

It's too much of an honor :-)

A final question: you wrote above:

I would love to increase our French user count, it's only around 700.

How do you know that?

cleidigh commented 1 year ago

@DenB10 TB on the addon site provides statistics. I have actually made these public so you should be able to see them. Try this link, otherwise I can find one. https://addons.thunderbird.net/EN-us/thunderbird/addon/printingtools-ng/statistics/usage/languages/?last=90

BTW reviews are always welcome :-)

@cleidigh

DenB10 commented 1 year ago

Ok, thanks for the info :+1: I didn't know that, but I often go on ATN!