v3.0.0 - Final Testing and Feedback

kiki-ja commented 1 year ago

PTNG 3.0.0b11 Thunderbird 115.0.1 64bit Windows 10 Pro 22H2 64bit

@cleidigh

Todo:

[] UI tweaks

Please adjust the width in two places. ・Attachments per Line

<label value="&attachmentsPerLine;"/>
<menulist id="num_atts_line" style="width: 100%" width="100%">

<label value="&attachmentsPerLine;"/>
<menulist id="num_atts_line" style="width: 80px">

・Default Printer [name list]

<menulist id="OutputPrinter" oncommand="printerChange();" style="padding-left: 24px"/>

<menulist id="OutputPrinter" oncommand="printerChange();" style="padding-left: 24px; width: 280px"/>

The screenshot is from b8, but is the same as b11. TAB3-per line diff

TAB5-default printer diff

ptng-options.xhtml.zip

@kiki-ja

kiki-ja commented 1 year ago

PTNG 3.0.0b11 Thunderbird 115.0.1 64bit Windows 10 Pro 22H2 64bit

@cleidigh

About add description for help. How about adding a shortcut for macOS?

[Befor]

LINE 494: - Debug output (copy from the Debug Console - access with Control-Shift-J)<br>

[After]

LINE 494: - Debug output (copy from the Debug Console - access with Ctrl+Shift+J (Windows & Linux), command+shift+J (macOS))<br>

@kiki-ja

cleidigh commented 1 year ago

@kiki-ja The dropdown element no longer self adjusts, setting the width makes it non reactive so I have to figure out how to make it expand to the largest item.

I don't understand what you are proposing and I don't know what the screenshots are. @cleidigh

cleidigh commented 1 year ago

@kiki-ja @tidebre67 @madvinegar @Mark3032

I think just posted b12 could be our release candidate. I have taken care of all outstanding issues in todo list including items from @kiki-ja above. I think you were referring to print shortcut on Mac. That is done as well.

So with some confirmation testing we are good to go from my perspective. @cleidigh

tidebre67 commented 1 year ago

@cleidigh all i use is working perfect. So if others do not report problems i have no objections to release. Again, you have done a great job, many tks.

Mark3032 commented 1 year ago

Works perfectly for me. As I said, maybe you could look at the issue of automatically printing the header at some point with some printers (PDF24, Samsung, etc.). These can be deselected manually for the current print job, but are checked again for the next print job (print header/footer).

Otherwise great work - thank you!!!

cleidigh commented 1 year ago

@Mark3032 I installed and tested PDF24 to see if I can understand and reproduce the issue you described at the end of

225

I was not able to find any unexpected behavior with PDF24 with respect to headers and footers. I should describe the way these are handled by PTNG and Thunderbird :

Headers and footers are set for each printer and can be edited by PTNG.
When you enter preview mode Thunderbird checks the headers and footers for the current printer. If any headers or footers are set to a non-empty value, then the Print Headers and footers option is checked. If ALL headers and footers are blank then the option is unchecked. If you have any headers or footers and you uncheck the option and print this will not print the existing headers and footers.

The important thing to understand relative to your comments is that the option in preview is NOT sticky, each time you enter preview it checks to see if any of the headers and footers are set and sets the option accordingly.

Knowing this does your observation still find a problem? As I have found no different behaviors with PDF24. @cleidigh

madvinegar commented 1 year ago

I installed b12 and tested it. (on win11).

As regards the "two page" bug with "original HTML" format when receiving outlook emails, it is still there, but as said, we need to wait from mozilla to correct this.

As regards the "file --> print" bug, the selection works, but the header does not have the border around it or any other option selected under the printNG options.

So right now in order to print my emails correctly, I have set the emails in simplified HTML format and I only use the PrintNG button.

kiki-ja commented 1 year ago

PTNG 3.0.0b12 Thunderbird 115.0.1 64bit Windows 10 Pro 22H2 64bit

@cleidigh

I think just posted b12 could be our release candidate.

All the functions I use work fine.

I think you were referring to print shortcut on Mac.

Thanks. However, what I wanted to convey was the description(keyboard shortcut key) of the help file.

@kiki-ja

cleidigh commented 1 year ago

@madvinegar Kalispera, can I get a clarification on your File/Print issue? I have both the Thunderbird Print and the Print NG in the menu. As you describe it sounds like the standard Thunderbird Print was invoked since none of the PTNG formatting is seen. Is that possible? @cleidigh

cleidigh commented 1 year ago

@kiki-ja Ok, sorry about that. Yes we can tweak help on that and I probably should change the button description as we now have two different ones. I will do that. @cleidigh

cleidigh commented 1 year ago

@kiki-ja I made small changes to the button section and added a section for the keyboard shortcuts. https://github.com/cleidigh/printing-tools-ng/blob/v3.0.0/src/chrome/content/help/locale/en-US/printingtoolsng-help.html

I think after this we are good. @cleidigh

kiki-ja commented 1 year ago

PTNG 3.0.0b12 Thunderbird 115.0.1、115.1.0RC2 64bit Windows 10 Pro 22H2 64bit

@cleidigh

I made small changes to the button section and added a section for the keyboard shortcuts. I think after this we are good.

I will start translating the Japanese for the added sections.

Duplicate key "O" in Menu bar --> [File] --> [Open (O)] and [Printing Tools NG Options (O)]. In v2.2.3 it was "G".

Menu-File-shortcutkey-O Duplicate

@kiki-ja

dstark commented 1 year ago

In Thunderbird 115.0.1 with PrintingTools NG 3.0b12 and FiltaQuilla 4.0b2, a filter set to automatically print an incoming message doesn't produce the expected PDF (FiltaQuilla is set to use PrintingTools NG for printing).

I can use PrintingTools NG 3.0b12 to print the message manually. And the filter can perform other actions as expected on the target message.

I'm not sure if this is an issue with FiltaQuilla sending the print instruction to PrintingTools or with PrintingTools picking it up from FiltaQuilla, so I thought I would start here with mentioning the issue in the interaction.

Thanks so much for all your work on the update for Thunderbird 115!

cleidigh commented 1 year ago

@dstark Thank you for reporting! I was not checking if FiltaQuila had beta for 115, my bad. I will check this asap. BTW if you put "trace1", no quotes, in the PTNG options you can see trace info in the debug console including external requests from FiltaQuila. @cleidigh

dstark commented 1 year ago

Thanks. The 4.0b2 is the latest FiltaQuilla beta for Thunderbird 115. Appreciate your tip about the debug console.

Here's what I get out when I click the PrintingTools NG button on a message—and, notably, get no PDF out.

PTNG: cmd_printng start: options : null [printingtoolsng-pengine.js:607:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: current window: Object { id: 3, focused: true, top: -8, left: -8, width: 1616, height: 916, incognito: false, type: "normal", state: "maximized", alwaysOnTop: false, … } [printingtoolsng-pengine.js:625:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: current tab: Object { id: 3, index: 0, windowId: 3, highlighted: true, active: true, status: "complete", width: 892, height: 654, cookieStoreId: "firefox-default", url: "imap://david%40jdavidstark%2Ecom@outlook.office365.com:993/fetch%3EUID%3E/INBOX%3E8303", … } [printingtoolsng-pengine.js:626:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: tab type : mail [printingtoolsng-pengine.js:627:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: tab url: imap://david%40jdavidstark%2Ecom@outlook.office365.com:993/fetch%3EUID%3E/INBOX%3E8303 [printingtoolsng-pengine.js:628:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: mailType: true [printingtoolsng-pengine.js:629:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: selectedMessageUris Array [ "imap-message://david%40jdavidstark.com@outlook.office365.com/INBOX#8303" ] [printingtoolsng-pengine.js:111:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: Use existing print hidden pane - multiple messages (1) [printingtoolsng-pengine.js:359:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: msgUris: Array [ "imap-message://david%40jdavidstark.com@outlook.office365.com/INBOX#8303" ] [printingtoolsng-pengine.js:360:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) Uncaught (in promise) ReferenceError: messenger is not defined PrintSelectedMessages chrome://printingtoolsng/content/printingtoolsng-pengine.js:423 [printingtoolsng-pengine.js:423:17](chrome://printingtoolsng/content/printingtoolsng-pengine.js)

And here's what I get when I do Ctrl+P—and do get a PDF out:

PTNG: cmd_printng start: options : undefined [printingtoolsng-pengine.js:607:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: current window: Object { id: 3, focused: true, top: -8, left: -8, width: 1616, height: 916, incognito: false, type: "normal", state: "maximized", alwaysOnTop: false, … } [printingtoolsng-pengine.js:625:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: current tab: Object { id: 3, index: 0, windowId: 3, highlighted: true, active: true, status: "complete", width: 892, height: 654, cookieStoreId: "firefox-default", url: "imap://david%40jdavidstark%2Ecom@outlook.office365.com:993/fetch%3EUID%3E/INBOX%3E8303", … } [printingtoolsng-pengine.js:626:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: tab type : mail [printingtoolsng-pengine.js:627:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: tab url: imap://david%40jdavidstark%2Ecom@outlook.office365.com:993/fetch%3EUID%3E/INBOX%3E8303 [printingtoolsng-pengine.js:628:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: mailType: true [printingtoolsng-pengine.js:629:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: selectedMessageUris Array [ "imap-message://david%40jdavidstark.com@outlook.office365.com/INBOX#8303" ] [printingtoolsng-pengine.js:111:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: Use existing print hidden pane - multiple messages (1) [printingtoolsng-pengine.js:359:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: msgUris: Array [ "imap-message://david%40jdavidstark.com@outlook.office365.com/INBOX#8303" ] [printingtoolsng-pengine.js:360:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”. 2 [test.html](chrome://printingtoolsng/content/test.html) Some cookies are misusing the recommended “SameSite“ attribute 3 TypeError: browser is null [BrowserElementParent.sys.mjs:21:21](resource://gre/actors/BrowserElementParent.sys.mjs) PTNG: Done [printingtoolsng-pengine.js:650:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js)

And when I try to run PrintingTools NG from a filter, I get no PDF output and the following:

FiltaQuilla 16:19:2.197 [22142 ms] print XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), setStringProperty: setStringProperty(), getStringProperty: getStringProperty(), getUint32Property: getUint32Property(), setUint32Property: setUint32Property(), isRead: Getter, isFlagged: Getter, isKilled: Getter, markRead: markRead(), markFlagged: markFlagged(), … } false [filtaquilla-util.js:282:13](chrome://filtaquilla/content/filtaquilla-util.js) FiltaQuilla 16:19:2.203 [6 ms] print.applyAction queue length: 1 Array [ XPCWrappedNative_NoHelper ] [filtaquilla-util.js:282:13](chrome://filtaquilla/content/filtaquilla-util.js) FiltaQuilla 16:19:2.204 [1 ms] printNextMessage queue length: 1 Array [ XPCWrappedNative_NoHelper ] [filtaquilla-util.js:282:13](chrome://filtaquilla/content/filtaquilla-util.js) FiltaQuilla 16:19:2.223 [19 ms] _printNextMessage(). Remaining queue length=0 XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), setStringProperty: setStringProperty(), getStringProperty: getStringProperty(), getUint32Property: getUint32Property(), setUint32Property: setUint32Property(), isRead: Getter, isFlagged: Getter, isKilled: Getter, markRead: markRead(), markFlagged: markFlagged(), … } [filtaquilla-util.js:282:13](chrome://filtaquilla/content/filtaquilla-util.js) PrintingTools NG Received a message from external add-on Object { id: 4, date: Date Mon Jul 31 2023 22:02:40 GMT-0500 (Central Daylight Time), author: '"CPAP.com" <cpap@info.cpap.com>', recipients: (1) […], ccList: [], bccList: [], subject: "Your CPAP.com Order #831086 Has Been Received - 7/31/2023 9:02:40 PM", read: true, new: false, headersOnly: false, … } [printingtoolsng-pengine.js:551:12](chrome://printingtoolsng/content/printingtoolsng-pengine.js) PTNG: PDF output to: D:\OneDrive\Downloads [printingtoolsng-pengine.js:508:14](chrome://printingtoolsng/content/printingtoolsng-pengine.js) ExtensionError: Invalid window ID: undefined 2 [ExtensionUtils.sys.mjs:50](resource://gre/modules/ExtensionUtils.sys.mjs) TypeError: messenger.messageServiceFromURI is not a function [printingtoolsng-pengine.js:523:34](chrome://printingtoolsng/content/printingtoolsng-pengine.js)

Does any of that help at all?

cleidigh commented 1 year ago

@dstark Thanks, I found the cause. Here is a quick fix, but I am still working on a related issue so WIP... https://github.com/cleidigh/printing-tools-ng/blob/v3.0.0/xpi/Beta/printing-tools-ng-3.0.0-b12p1-tb.xpi @cleidigh

cleidigh commented 1 year ago

@tidebre67 @kiki-ja Just released v3 to the review Q. Thanks again for all the help. Will be interesting to see the pickup. @cleidigh

kiki-ja commented 1 year ago

Thank you for released v3.0.0. I hope it will be used by many users.

I will translate and send you the version information for ATN.

@kiki-ja

madvinegar commented 1 year ago

@cleidigh

Chris hi again. Is there a way to replace the file > Print option with the "Print...NG" option?

In the previous version (Printing tools v2.2.2), as soon as we installed Printing tools NG, the native "Print" option was removed.

Can we do the same here so as when we open the file menu, to only see the "Print... NG" option?

Στιγμιότυπο οθόνης 2023-09-07, 6 27 08 μμ

cleidigh commented 1 year ago

Hey @madvinegar sorry to be slow... Yes I know this is not ideal. The menus have all changed with the new apis. I have refrained from trying hacks as some addons have caused havoc messing with the menus. I may look at it, but really getting the apis to support it is ideal. @cleidigh

madvinegar commented 1 year ago

No worries Chris. It is more of a cosmetic nuisance. The actual printNG works great and we thank you so much for this.

cleidigh / printing-tools-ng

v3.0.0 - Final Testing and Feedback #229

225