cleidigh / printing-tools-ng

PrintingTools NG Thunderbird Extension - Printing Utilities
Other
36 stars 17 forks source link

Header font size not responsive to set value #235

Open KC-T opened 1 year ago

KC-T commented 1 year ago

Windows 11 - Thunderbird 115.3.2 - PrintingTools 3.0.0

I have reduced the volume of printing substantially and am not aware of this problem which may have existed for some time.

The printed header font size does not vary when the pixel size is changed. I would like to reduce it to reduce the paper used.

cleidigh commented 1 year ago

@KC-T Hi there , it's been a while, hope all is well. @tidebre67 reported this also. Are you able to change the body font size? @tidebre67 can. I tested and cannot change either size. Thunderbird has to be the issue. I am right in the middle of a critical update for IETNG so I can't jump on this yet, but will try to soon.

@tidebre67 Can you set debug options to: finaloutput and then print a three line email and capture the console output. @cleidigh

KC-T commented 1 year ago

The body font sizes can be changed while the header font size remains unchanged whether or not the change is specified.

tidebre67 commented 1 year ago

@cleidigh

Christopher, i hope that this is that what you wanted, if not pls let me know.

NotFoundError: No such JSWindowActor 'DevToolsFrame' 19 XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), setStringProperty: setStringProperty(), getStringProperty: getStringProperty(), getUint32Property: getUint32Property(), setUint32Property: setUint32Property(), isRead: Getter, isFlagged: Getter, isKilled: Getter, markRead: markRead(), markFlagged: markFlagged(), … } printingtoolsng-pengine.js:97:13 PTNG: final output:

Re: [thundernest/import-export-tools-ng] Change From dates in separator lines on MBOX export (Issue #455)

Thomas Tiedemann

Datum:
Dienstag, 17 Oktober 2023 MESZ 22:11:46 [GMT +0200]
Von:
Christopher Leidigh <notifications@github.com>
An:
thundernest/import-export-tools-ng <import-export-tools-ng@noreply.github.com>
Cc:
Subscribed <subscribed@noreply.github.com>
Betreff:
Re: [thundernest/import-export-tools-ng] Change From dates in separator lines on MBOX export (Issue #455)

Reopened #455.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <thundernest/import-export-tools-ng/issue/455/issue_event/10683269837@github.com>

printUI: Unexpected duplex value: 1515870810 print.js:1420 TypeError: browser is null BrowserElementParent.sys.mjs:21:21 mailnews.pop3.86: Got an error name=pop3ServerBusy Pop3Client.jsm:1445:18

cleidigh commented 1 year ago

@tidebre67 @KC-T Thanks guys Thomas the console output got rendered as html by Github! I think you have to place it between triple backtick characters. So type three backticks, enter paste output then return and three backticks

This allows pasting code without gh messing with it.

All I can reproduce here except body also doesn't use size. So I can do debugging and then hopefully figure out difference. @cleidigh

tidebre67 commented 1 year ago

@cleidigh i hope it looks correct now, if not pls let me know

WebExtensions: messageWindow OL messageWindowOL.js:13
Einige Cookies verwenden das empfohlene "SameSite"-Attribut inkorrekt. 3
XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), setStringProperty: setStringProperty(), getStringProperty: getStringProperty(), getUint32Property: getUint32Property(), setUint32Property: setUint32Property(), isRead: Getter, isFlagged: Getter, isKilled: Getter, markRead: markRead(), markFlagged: markFlagged(), … }
printingtoolsng-pengine.js:97:13
PTNG: final output:

<html><head>
<title>Re: [thundernest/import-export-tools-ng] Change From dates in separator lines on MBOX export (Issue #455)</title>
<link rel="important stylesheet" href="chrome://messagebody/skin/messageBody.css">
</head>
<body>
<h3 class="ptng-tophdr">Thomas Tiedemann</h3><table class="moz-header-part1 moz-main-header" style="font-family: Century Schoolbook; table-layout: fixed; margin-right: 10px; border-top: 2.5px solid grey; background-color: rgb(255, 255, 255);" width="100%" cellspacing="0" cellpadding="0" border="0"><tbody><tr><td style="vertical-align: top; padding: 3px 0px 0px 5px;" width="108px"><div class="moz-header-display-name" style="display: inline; padding-right: 0px;">Datum: </div></td><td style="padding: 0px 0px 0px 5px;">Dienstag, 17 Oktober 2023  MESZ 22:11:46 [GMT +0200]</td></tr><tr><td style="vertical-align: top; padding: 0px 0px 0px 5px;" width="108px"><div class="moz-header-display-name" style="display: inline; padding-right: 0px;">Von: </div></td><td style="padding: 0px 0px 0px 5px;">Christopher Leidigh &lt;notifications@github.com&gt;</td></tr><tr><td style="vertical-align: top; padding: 0px 0px 0px 5px;" width="108px"><div class="moz-header-display-name" style="display: inline; padding-right: 0px;">An: </div></td><td style="padding: 0px 0px 0px 5px;">thundernest/import-export-tools-ng &lt;import-export-tools-ng@noreply.github.com&gt;</td></tr><tr><td style="vertical-align: top; padding: 0px 0px 0px 5px;" width="108px"><div class="moz-header-display-name" style="display: inline; padding-right: 0px;">Cc: </div></td><td style="padding: 0px 0px 0px 5px;">Subscribed &lt;subscribed@noreply.github.com&gt;</td></tr><tr><td style="vertical-align: top; padding: 0px 0px 0px 5px;" width="108px"><div class="moz-header-display-name subjectHdr" style="display: inline; padding-right: 0px; float: left;">Betreff: </div></td><td style="padding: 0px 0px 0px 5px;"><div style="overflow: hidden; overflow-wrap: break-word; text-overflow: ellipsis; padding-right: 0px;">Re: [thundernest/import-export-tools-ng] Change From dates in separator lines on MBOX export (Issue #455)</div></td></tr></tbody></table><table class="moz-header-part2 moz-main-header" style="font-family: Century Schoolbook; display: none; border-left: 1px solid black; border-right: 1px solid black; border-bottom: 1px solid black;" width="100%" cellspacing="0" cellpadding="0" border="0"><tbody></tbody></table><br>

<meta http-equiv="content-type" content="text/html; "><div class="moz-text-html" lang="x-unicode"><p></p>
<p dir="auto">Reopened <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1928651157" data-permission-text="Title is private" data-url="https://github.com/thundernest/import-export-tools-ng/issues/455" data-hovercard-type="issue" data-hovercard-url="/thundernest/import-export-tools-ng/issues/455/hovercard" href="https://github.com/thundernest/import-export-tools-ng/issues/455">#455</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly, <a href="https://github.com/thundernest/import-export-tools-ng/issues/455#event-10683269837">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AKSQ7XWGZ53ILV3PVR4UTHTX73RAFAVCNFSM6AAAAAA5UQT5OSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGY4DGMRWHE4DGNY">unsubscribe</a>.<br>You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AKSQ7XQOXRKVLBHW2G52MWDX73RAFA5CNFSM6AAAAAA5UQT5OSWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAE7GFYLGQ.gif" alt="" shrinktofit="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;thundernest/import-export-tools-ng/issue/455/issue_event/10683269837</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/thundernest/import-export-tools-ng/issues/455#event-10683269837",
"url": "https://github.com/thundernest/import-export-tools-ng/issues/455#event-10683269837",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</div>

</body></html>
printUI: Unexpected duplex value:  1515870810 print.js:1420
TypeError: browser is null BrowserElementParent.sys.mjs:21:21
cleidigh commented 1 year ago

@KC-T @tidebre67 I found the issue and the fix, but I am not clear why and when the issue started. I have to do a bunch of manual merge work before I can make any beta. I'll try to weave it in between the IETNG work. @tidebre67 See how you can now see the html tags in your last post. @cleidigh

cleidigh commented 1 year ago

@KC-T @tidebre67 @kiki-ja (in case you also change font sizes)

I took some time off IETNG and got my house in order for v3.0.1 and beta. This is odd because I have seen some inconsistent behavior. I don't know why body font sizes worked... See if b1 remains consistent. https://github.com/cleidigh/printing-tools-ng/blob/v3.0.1/xpi/beta/printing-tools-ng-3.0.1-b1-tb.xpi

@cleidigh

kiki-ja commented 1 year ago

@cleidigh

PrintingTools NG 3.0.1-b1 Thunderbird 115.4.1 64bit Windows 10 Pro 22H2 64bit

The problem is not reproduced in my above environment and everything is normal. The conditions tested are as follows.

@kiki-ja

tidebre67 commented 1 year ago

@cleidigh

Windows 10 Home 64-Bit TB: 115.4.1 (64-Bit) PrintingTools NG 3.0.1-b1 Font: Century Schoolbook

change of font size works with the new beta. But there is a strange issue now, font size of both header and body set to 12 but header font looks smaller than body font

Re-  cleidigh-printing-tools-ng  Header font size not responsive to set value (Issue #235)-1

tidebre67 commented 1 year ago

@cleidigh pls ignore. seems to be a problem with my laptop, on desktop all looks correct.

KC-T commented 1 year ago

Windows 11 - Thunderbird 115.3.2

PrintingTools 3.0.1-b1 (beta) is working. Header and body font sizes are both responsive.

cleidigh commented 1 year ago

@KC-T @kiki-ja @tidebre67 Thanks sounds like that was the trick. @cleidigh

th-joerger commented 1 year ago

Footer also ignores Font and size settings!

cleidigh commented 1 year ago

@th-joerger Unfortunately it is not possible to do any font manipulation on the page headers and footers. PTNG allows you to change the email headers ( with beta) @cleidigh