Settings dialog comes up with wrong background colors in darkmode under MacOS

cleidigh / printing-tools-ng

PrintingTools NG Thunderbird Extension - Printing Utilities

Other

36 stars 17 forks source link

Settings dialog comes up with wrong background colors in darkmode under MacOS #238

Open holle opened 1 year ago

holle commented 1 year ago

I just discovered this interesting addon and was eager to try it out.

Facts first:

I am running Thunderbird 115.4.2 on both Linux and MacOS.
I have installed v3.0.1 of the addon.
Both systems are using the embedded "system theme".
I am using the MacOS darkmode (and an equivalent under Linux).
While trying out the addon (on MacOS, I can try it on Linux next week) I discovered the settings dialog is using the system font colours (white-ish) while having a bright grey background. This makes adjusting any settings a bit complicated.

Please see the attached screenshot for details. Settings Dialog

I am able and willing to play around with any test versions you have for me to try out and/or adjust any special settings.

Cheers, Holger

cleidigh commented 1 year ago

@holle Well that is not very useful %-(

I have an old mac I use for testing, but never really anything with system themes. What happens if you have the os in light mode and try both Thunderbird light and dark mode? Also where and what do I set on my mac to match your theme settings? @cleidigh

holle commented 12 months ago

Hi @cleidigh,

thanks for the quick reply. Yes, if I switch to the "light" theme, everything is readable, as expected. Where and if you can switch darkmode on/off on an older MacOS depends on the version. According to Wikipedia this is available since macOS 10.14 Mojave: https://en.wikipedia.org/wiki/MacOS Where the setting is available really depends on your MacOS version. Here is an example for an older MacOS: https://medium.com/@geert.cuppens/macos-keyboard-shortcut-to-toggle-dark-mode-2724c9f7fbfe Maybe the Apple Script helps to toggle it for you?

Cheers, Holger

PS: Problem is gone, TB needed a restart ~~funny side note, I cannot install the addon under my Linux TB Supernova 115.4.2 -- not getting any errors, though, investigating~~ PPS: Under Linux the "darkmode" of the "system-theme" is detected properly and the colors match perfectly with the rest of the application

cleidigh commented 12 months ago

@holle Ok so you are all good then? @cleidigh

holle commented 12 months ago

Hi @cleidigh,

no, sorry, this does not solve my problem since I want to use dark mode on my MacOS and across all apps. Did you define any css statically in the addon? I ask because other addons correctly switch their colors when the theme is switched. Maybe you can point me to the right place in the code and I could have look?

Cheers, Holger